Skip to content

Commit eff4745

Browse files
committed
Python: Refactor argument matching
1 parent 2ea71f5 commit eff4745

File tree

1 file changed

+2
-6
lines changed
  • python/ql/src/experimental/semmle/python/frameworks

1 file changed

+2
-6
lines changed

python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -407,9 +407,7 @@ private module Stdlib {
407407
}
408408

409409
override DataFlow::Node getCommand() {
410-
result.asCfgNode() = node.getArg(0)
411-
or
412-
result.asCfgNode() = node.getArgByName("cmd")
410+
result.asCfgNode() in [node.getArg(0), node.getArgByName("cmd")]
413411
}
414412
}
415413

@@ -476,9 +474,7 @@ private module Stdlib {
476474
PlatformPopenCall() { node.getFunction() = platform_attr("popen").asCfgNode() }
477475

478476
override DataFlow::Node getCommand() {
479-
result.asCfgNode() = node.getArg(0)
480-
or
481-
result.asCfgNode() = node.getArgByName("cmd")
477+
result.asCfgNode() in [node.getArg(0), node.getArgByName("cmd")]
482478
}
483479
}
484480
}

0 commit comments

Comments
 (0)