No need to cache isUnreachableInCall any more

owen-mc · owen-mc · commit f0fd501a2343 · 2021-05-12T08:54:58.000+01:00
diff --git a/ql/src/semmle/go/dataflow/internal/DataFlowPrivate.qll b/ql/src/semmle/go/dataflow/internal/DataFlowPrivate.qll
@@ -236,7 +236,6 @@ private ControlFlow::ConditionGuardNode getAFalsifiedGuard(DataFlowCall call) {
 /**
  * Holds if the node `n` is unreachable when the call context is `call`.
  */
-cached
 predicate isUnreachableInCall(Node n, DataFlowCall call) {
   getAFalsifiedGuard(call).dominates(n.getBasicBlock())
 }

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,6 @@ private ControlFlow::ConditionGuardNode getAFalsifiedGuard(DataFlowCall call) {`
`236`	`236`	`/**`
`237`	`237`	* Holds if the node `n` is unreachable when the call context is `call`.
`238`	`238`	`*/`
`239`		`-cached`
`240`	`239`	`predicate isUnreachableInCall(Node n, DataFlowCall call) {`
`241`	`240`	`getAFalsifiedGuard(call).dominates(n.getBasicBlock())`
`242`	`241`	`}`