Skip to content

Commit f341234

Browse files
JLLeitschuhfelicitymayyo-h
authored
Apply suggestions from code review
Co-Authored-By: Felicity Chapman <felicitymay@github.com> Co-Authored-By: yo-h <55373593+yo-h@users.noreply.github.com>
1 parent 21193bd commit f341234

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

java/ql/src/Security/CWE/CWE-829/InsecureDependencyResolution.qhelp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ against your project's users.
1212
</p>
1313

1414
<p>This vulnerability has a
15-
<a href="https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H&version=3.1">
15+
<a href="https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H&amp;version=3.1">
1616
CVSS v3.1 base score of 8.1/10
1717
</a>.</p>
1818

@@ -37,7 +37,7 @@ The first shows the use of HTTP, the second shows the use of HTTPS.
3737
<references>
3838
<li>
3939
Research:
40-
<a href="https://medium.com/bugbountywriteup/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb?source=friends_link&sk=3c99970c55a899ad9ef41f126efcde0e">
40+
<a href="https://medium.com/bugbountywriteup/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb?source=friends_link&amp;sk=3c99970c55a899ad9ef41f126efcde0e">
4141
Want to take over the Java ecosystem? All you need is a MITM!
4242
</a>
4343
</li>

java/ql/src/Security/CWE/CWE-829/InsecureDependencyResolution.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/**
22
* @name Failure to use HTTPS or SFTP URL in Maven artifact upload/download
33
* @description Non-HTTPS connections can be intercepted by third parties.
4-
* @kind path-problem
4+
* @kind problem
55
* @problem.severity error
6-
* @precision very high
6+
* @precision very-high
77
* @id java/maven/non-https-url
88
* @tags security
99
* external/cwe/cwe-319
@@ -35,4 +35,4 @@ from DeclaredRepository repository
3535
where repository.isInsecureRepositoryUsage()
3636
select
3737
repository,
38-
"Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to repository " + repository.getUrl()
38+
"Downloading or uploading artifacts over insecure protocol (eg. http or ftp) to/from repository " + repository.getUrl()

0 commit comments

Comments
 (0)