Merge pull request #848 from calumgrant/cs/lgtm-suppress-alerts

C#: Suppress cs/catch-of-all-exceptions

Author: rdmarsh2

csharp/autobuilder/Semmle.Autobuild/DotNetRule.cs

@@ -112,7 +112,7 @@ static BuildScript DownloadDotNet(Autobuilder builder, string installDir)
                     var o = JObject.Parse(File.ReadAllText(path));
                     version = (string)o["sdk"]["version"];
                 }
-                catch
+                catch  // lgtm[cs/catch-of-all-exceptions]
                 {
                     // not a valid global.json file
                     continue;

csharp/autobuilder/Semmle.Autobuild/Project.cs

@@ -63,7 +63,8 @@ public Project(Autobuilder builder, string path) : base(builder, path)
                         ToolsVersion = new Version(toolsVersion);
                         ValidToolsVersion = true;
                     }
-                    catch   // Generic catch clause - Version constructor throws about 5 different exceptions.
+                    catch  // lgtm[cs/catch-of-all-exceptions]
+                           // Generic catch clause - Version constructor throws about 5 different exceptions.
                     {
                         builder.Log(Severity.Warning, "Project {0} has invalid tools version {1}", path, toolsVersion);
                     }

csharp/extractor/Semmle.Util/CanonicalPathCache.cs

@@ -136,7 +136,7 @@ public override string GetCanonicalPath(string path, IPathCache cache)
                         entries[0] :
                         Path.Combine(parentPath, name);
                 }
-                catch (Exception)
+                catch  // lgtm[cs/catch-of-all-exceptions]
                 {
                     // IO error or security error querying directory.
                     return Path.Combine(parentPath, name);