Skip to content

Commit f40b406

Browse files
author
Max Schaefer
committed
JavaScript: Address review comments.
1 parent c9132ca commit f40b406

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

javascript/ql/src/semmle/javascript/ApiGraphs.qll

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,7 @@ module API {
703703
boundArgs = 0
704704
or
705705
exists(DataFlow::CallNode promisify |
706-
promisify = API::moduleImport(["util", "bluebird"]).getMember("promisify").getACall()
706+
promisify = DataFlow::moduleImport(["util", "bluebird"]).getAMemberCall("promisify")
707707
|
708708
trackUseNode(nd, false, boundArgs, t.continue()).flowsTo(promisify.getArgument(0)) and
709709
promisified = true and
@@ -713,7 +713,7 @@ module API {
713713
exists(DataFlow::PartialInvokeNode pin, DataFlow::Node pred, int predBoundArgs |
714714
trackUseNode(nd, promisified, predBoundArgs, t.continue()).flowsTo(pred) and
715715
result = pin.getBoundFunction(pred, boundArgs - predBoundArgs) and
716-
boundArgs <= 10
716+
boundArgs in [0 .. 10]
717717
)
718718
or
719719
exists(StepSummary summary |
@@ -779,7 +779,8 @@ module API {
779779

780780
private DataFlow::SourceNode awaited(DataFlow::InvokeNode call, DataFlow::TypeTracker t) {
781781
t.startInPromise() and
782-
exists(MkSyntheticCallbackArg(_, _, call))
782+
exists(MkSyntheticCallbackArg(_, _, call)) and
783+
result = call
783784
or
784785
exists(DataFlow::TypeTracker t2 | result = awaited(call, t2).track(t2, t))
785786
}

0 commit comments

Comments
 (0)