add support for the promise.allsettled library

erik-krogh · erik-krogh · commit f53955fb5e0d · 2021-06-22T10:30:33.000+02:00
diff --git a/javascript/change-notes/2021-06-18-promises.md b/javascript/change-notes/2021-06-18-promises.md
@@ -12,4 +12,5 @@ lgtm,codescanning
     [pinkie](https://npmjs.com/package/pinkie),
     [synchronous-promise](https://npmjs.com/package/synchronous-promise),
     [any-promise](https://npmjs.com/package/any-promise),
-    [lie](https://npmjs.com/package/lie)
+    [lie](https://npmjs.com/package/lie),
+    [promise.allsettled](https://npmjs.com/package/promise.allsettled)
diff --git a/javascript/ql/src/semmle/javascript/Promises.qll b/javascript/ql/src/semmle/javascript/Promises.qll
@@ -157,8 +157,11 @@ class ResolvedES2015PromiseDefinition extends ResolvedPromiseDefinition {
  */
 class AggregateES2015PromiseDefinition extends PromiseCreationCall {
   AggregateES2015PromiseDefinition() {
+    exists(string m | m = "all" or m = "race" or m = "any" or m = "allSettled" |
       this = getAPromiseObject().getAMemberCall(m)
     )
+    or
+    this = DataFlow::moduleImport("promise.allsettled").getACall()
   }
 
   override DataFlow::Node getValue() {

Original file line number	Diff line number	Diff line change
`@@ -157,8 +157,11 @@ class ResolvedES2015PromiseDefinition extends ResolvedPromiseDefinition {`
`157`	`157`	`*/`
`158`	`158`	`class AggregateES2015PromiseDefinition extends PromiseCreationCall {`
`159`	`159`	`AggregateES2015PromiseDefinition() {`
	`160`	`+ exists(string m \| m = "all" or m = "race" or m = "any" or m = "allSettled" \|`
`160`	`161`	`this = getAPromiseObject().getAMemberCall(m)`
`161`	`162`	`)`
	`163`	`+ or`
	`164`	`+ this = DataFlow::moduleImport("promise.allsettled").getACall()`
`162`	`165`	`}`
`163`	`166`
`164`	`167`	`override DataFlow::Node getValue() {`