Skip to content

Commit f758b67

Browse files
committed
JS: Openly recommend SummarizedCallable
1 parent 249104b commit f758b67

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

javascript/ql/lib/semmle/javascript/dataflow/AdditionalFlowSteps.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ private import semmle.javascript.internal.CachedStages
2828
*
2929
* This class is a singleton, and thus subclasses do not need to specify a characteristic predicate.
3030
*
31+
* As an alternative to this class, consider using `DataFlow::SummarizedCallable`.
32+
*
3133
* Note: For performance reasons, all subclasses of this class should be part
3234
* of the standard library. Use `isAdditionalFlowStep` for query-specific flow steps.
3335
*/

javascript/ql/lib/semmle/javascript/dataflow/AdditionalTaintSteps.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ private import semmle.javascript.internal.CachedStages
1111
*
1212
* This class is a singleton, and thus subclasses do not need to specify a characteristic predicate.
1313
*
14+
* As an alternative to this class, consider using `DataFlow::SummarizedCallable`.
15+
*
1416
* Note: For performance reasons, all subclasses of this class should be part
1517
* of the standard library. Use `isAdditionalFlowStep` for query-specific taint steps.
1618
*/

javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1935,4 +1935,5 @@ module DataFlow {
19351935
import internal.FunctionWrapperSteps
19361936
import internal.sharedlib.DataFlow
19371937
import internal.BarrierGuards
1938+
import FlowSummary
19381939
}

0 commit comments

Comments
 (0)