Merge pull request #4094 from tamasvajk/feature/comp-gen-array-size

C# Compiler generated flag for length arguments of implicitly sized arrays

Author: hvitved

csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/ArrayCreation.cs

@@ -17,7 +17,7 @@ protected ExplicitArrayCreation(ExpressionNodeInfo info) : base(info.SetKind(Exp
 
         protected abstract ArrayTypeSyntax TypeSyntax { get; }
 
-        public abstract InitializerExpressionSyntax  Initializer { get;  }
+        public abstract InitializerExpressionSyntax Initializer { get; }
 
         protected override void PopulateExpression(TextWriter trapFile)
         {
@@ -48,7 +48,7 @@ protected override void PopulateExpression(TextWriter trapFile)
                             ExprKind.INT_LITERAL,
                             this,
                             child,
-                            false,
+                            true,
                             size.ToString());
 
                         new Expression(info);

csharp/ql/test/library-tests/expressions/ArrayCreation11.expected

@@ -0,0 +1,3 @@
+| expressions.cs:168:27:168:44 | array creation of type Object[] | expressions.cs:168:27:168:44 | 1 | true |
+| expressions.cs:409:23:409:65 | array creation of type Int32[,] | expressions.cs:409:23:409:65 | 3 | true |
+| expressions.cs:409:23:409:65 | array creation of type Int32[,] | expressions.cs:409:23:409:65 | 3 | true |

csharp/ql/test/library-tests/expressions/ArrayCreation11.ql

@@ -0,0 +1,13 @@
+/**
+ * @name Test for array creations
+ */
+
+import csharp
+
+private boolean isImplicit(Expr expr) {
+  if expr.isImplicit() then result = true else result = false
+}
+
+from ArrayCreation ac, Expr expr
+where ac.isImplicitlySized() and not ac.isImplicitlyTyped() and expr = ac.getALengthArgument()
+select ac, expr, isImplicit(expr)