C#: Add more data flow tests for assignments

hvitved · hvitved · commit f8791c884f36 · 2019-11-15T11:30:40.000+01:00
diff --git a/csharp/ql/test/library-tests/dataflow/local/DataFlowStep.expected b/csharp/ql/test/library-tests/dataflow/local/DataFlowStep.expected
@@ -582,6 +582,8 @@
 | LocalDataFlow.cs:464:50:464:52 | value | LocalDataFlow.cs:464:64:464:68 | access to parameter value |
 | LocalDataFlow.cs:470:41:470:47 | tainted | LocalDataFlow.cs:472:15:472:21 | access to parameter tainted |
 | LocalDataFlow.cs:475:44:475:53 | nonTainted | LocalDataFlow.cs:477:15:477:24 | access to parameter nonTainted |
+| LocalDataFlow.cs:480:44:480:44 | x | LocalDataFlow.cs:483:21:483:21 | access to parameter x |
+| LocalDataFlow.cs:480:67:480:68 | os | LocalDataFlow.cs:486:32:486:33 | access to parameter os |
 | SSA.cs:5:17:5:17 | SSA entry def(this.S) | SSA.cs:67:9:67:14 | access to field S |
 | SSA.cs:5:17:5:17 | this | SSA.cs:67:9:67:12 | this access |
 | SSA.cs:5:26:5:32 | tainted | SSA.cs:8:24:8:30 | access to parameter tainted |
diff --git a/csharp/ql/test/library-tests/dataflow/local/LocalDataFlow.cs b/csharp/ql/test/library-tests/dataflow/local/LocalDataFlow.cs
@@ -476,4 +476,13 @@ public void NonTaintedParameter(string nonTainted)
     {
         Check(nonTainted);
     }
+
+    public void AssignmentFlow(IDisposable x, IEnumerable<object> os)
+    {
+        IDisposable x1;
+        using (x1 = x) { }
+
+        IEnumerable<object> os2;
+        foreach(var o in os2 = os) { }
+    }
 }
diff --git a/csharp/ql/test/library-tests/dataflow/local/TaintTrackingStep.expected b/csharp/ql/test/library-tests/dataflow/local/TaintTrackingStep.expected
@@ -730,6 +730,10 @@
 | LocalDataFlow.cs:470:41:470:47 | tainted | LocalDataFlow.cs:472:15:472:21 | access to parameter tainted |
 | LocalDataFlow.cs:475:44:475:53 | nonTainted | LocalDataFlow.cs:475:44:475:53 | nonTainted |
 | LocalDataFlow.cs:475:44:475:53 | nonTainted | LocalDataFlow.cs:477:15:477:24 | access to parameter nonTainted |
+| LocalDataFlow.cs:480:44:480:44 | x | LocalDataFlow.cs:480:44:480:44 | x |
+| LocalDataFlow.cs:480:44:480:44 | x | LocalDataFlow.cs:483:21:483:21 | access to parameter x |
+| LocalDataFlow.cs:480:67:480:68 | os | LocalDataFlow.cs:480:67:480:68 | os |
+| LocalDataFlow.cs:480:67:480:68 | os | LocalDataFlow.cs:486:32:486:33 | access to parameter os |
 | SSA.cs:5:17:5:17 | SSA entry def(this.S) | SSA.cs:67:9:67:14 | access to field S |
 | SSA.cs:5:17:5:17 | this | SSA.cs:67:9:67:12 | this access |
 | SSA.cs:5:26:5:32 | tainted | SSA.cs:5:26:5:32 | tainted |

Original file line number	Diff line number	Diff line change
`@@ -476,4 +476,13 @@ public void NonTaintedParameter(string nonTainted)`
`476`	`476`	`{`
`477`	`477`	`Check(nonTainted);`
`478`	`478`	`}`
	`479`	`+`
	`480`	`+ public void AssignmentFlow(IDisposable x, IEnumerable<object> os)`
	`481`	`+ {`
	`482`	`+ IDisposable x1;`
	`483`	`+ using (x1 = x) { }`
	`484`	`+`
	`485`	`+ IEnumerable<object> os2;`
	`486`	`+ foreach(var o in os2 = os) { }`
	`487`	`+ }`
`479`	`488`	`}`