Skip to content

Commit f8f3770

Browse files
committed
JS: BadRandomness can just use type-tracking now
1 parent 52c2e37 commit f8f3770

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

javascript/ql/src/Security/CWE-327/BadRandomness.ql

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,6 @@ private DataFlow::Node goodRandom(DataFlow::TypeTracker t, DataFlow::SourceNode
8787
or
8888
exists(DataFlow::TypeTracker t2 | t = t2.smallstep(goodRandom(t2, source), result))
8989
or
90-
// re-using the collection steps for `Set`.
91-
exists(DataFlow::TypeTracker t2 |
92-
result = CollectionsTypeTracking::collectionStep(goodRandom(t2, source), t, t2)
93-
)
94-
or
9590
InsecureRandomness::isAdditionalTaintStep(goodRandom(t.continue(), source), result) and
9691
// bit shifts and multiplication by powers of two are generally used for constructing larger numbers from smaller numbers.
9792
not exists(BinaryExpr binop | binop = result.asExpr() |

0 commit comments

Comments
 (0)