Skip to content

Commit fb37330

Browse files
RasmusWLtausbn
andauthored
Python: Fix grammar
Co-authored-by: Taus <tausbn@github.com>
1 parent e0016f6 commit fb37330

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

python/tools/recorded-call-graph-metrics/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ also known as _call graph tracing_.
44

55
Execute a python program and for each call being made, record the call and callee. This allows us to compare call graph resolution from static analysis with actual data -- that is, can we statically determine the target of each actual call correctly.
66

7-
Using the call graph tracer does incur heave toll on the performance. Expect 10x longer to execute program.
7+
Using the call graph tracer does incur a heavy toll on the performance. Expect 10x longer to execute the program.
88

99
Number of calls recorded vary a little from run to run. I have not been able to pinpoint why.
1010

@@ -25,7 +25,7 @@ $ head -n 100 projects/*/Metrics.txt
2525

2626
### Expanding set of projects
2727

28-
It should be fairly straight forward to expand the set of projects. Most projects use `tox` for running their tests against multiple python versions. I didn't look into any kind of integration, but have manually picked out the instructions required to get going.
28+
It should be fairly straightforward to expand the set of projects. Most projects use `tox` for running their tests against multiple python versions. I didn't look into any kind of integration, but have manually picked out the instructions required to get going.
2929

3030
As an example, compare the [`tox.ini`](https://github.com/pallets/flask/blob/21c3df31de4bc2f838c945bd37d185210d9bab1a/tox.ini) file from flask with the configuration
3131

python/tools/recorded-call-graph-metrics/ql/lib/RecordedCalls.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ class IdentifiedRecordedCall extends XMLRecordedCall {
179179
// - all these calls were recorded
180180
//
181181
// without this `strictcount`, in the case `func(); func(); func()`, if 1 of the calls
182-
// is not recorded, we woulld still mark the other two recorded calls as valid
182+
// is not recorded, we would still mark the other two recorded calls as valid
183183
// (which is not following the rules above). + 1 to count `this` as well.
184184
strictcount(this.getACall()) = strictcount(this.getOtherWithSameSetOfCalls()) + 1 and
185185
forex(XMLRecordedCall rc | rc = this.getOtherWithSameSetOfCalls() |

python/tools/recorded-call-graph-metrics/ql/query/Metrics.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import lib.RecordedCalls
22

3-
// colum i is just used for sorting
3+
// column i is just used for sorting
44
from string text, float number, float ratio, int i
55
where
66
exists(int all_rcs | all_rcs = count(XMLRecordedCall rc) and ratio = number / all_rcs |

0 commit comments

Comments
 (0)