C#: Fix ID of TypeReferenceType for top level classes

tamasvajk · tamasvajk · commit fc5f6c520341 · 2020-12-09T21:00:39.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction.CIL/Entities/TypeReferenceType.cs b/csharp/extractor/Semmle.Extraction.CIL/Entities/TypeReferenceType.cs
@@ -134,6 +134,7 @@ public override void WriteId(TextWriter trapFile, bool inContext)
             if (ct != null)
             {
                 ct.GetId(trapFile, inContext);
+                trapFile.Write('.');
             }
             else
             {
@@ -145,10 +146,10 @@ public override void WriteId(TextWriter trapFile, bool inContext)
                 if (!ContainingNamespace.IsGlobalNamespace)
                 {
                     ContainingNamespace.WriteId(trapFile);
+                    trapFile.Write('.');
                 }
             }
 
-            trapFile.Write('.');
             trapFile.Write(Cx.GetString(tr.Name));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,7 @@ public override void WriteId(TextWriter trapFile, bool inContext)`
`134`	`134`	`if (ct != null)`
`135`	`135`	`{`
`136`	`136`	`ct.GetId(trapFile, inContext);`
	`137`	`+ trapFile.Write('.');`
`137`	`138`	`}`
`138`	`139`	`else`
`139`	`140`	`{`
`@@ -145,10 +146,10 @@ public override void WriteId(TextWriter trapFile, bool inContext)`
`145`	`146`	`if (!ContainingNamespace.IsGlobalNamespace)`
`146`	`147`	`{`
`147`	`148`	`ContainingNamespace.WriteId(trapFile);`
	`149`	`+ trapFile.Write('.');`
`148`	`150`	`}`
`149`	`151`	`}`
`150`	`152`
`151`		`- trapFile.Write('.');`
`152`	`153`	`trapFile.Write(Cx.GetString(tr.Name));`
`153`	`154`	`}`
`154`	`155`