Skip to content

Commit fd293d0

Browse files
committed
JS: Address doc review
1 parent 04f51be commit fd293d0

File tree

4 files changed

+5
-2
lines changed

4 files changed

+5
-2
lines changed

javascript/change-notes/2020-11-25-prototype-pollution.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ lgtm,codescanning
66
This highlights indirect modification of `Object.prototype` via an unsafe `merge` call taking a user-controlled object as argument.
77
* The query previously named "Prototype pollution in utility function" (`js/prototype-pollution-utility`) has been renamed to "Prototype-polluting function".
88
This query highlights the implementation of an unsafe `merge` function, to ensure a robust API is exposed downstream.
9-
* The above queries have been moved to the Security/CWE-915 folder, and tagged with CWE-079, CWE-094, CWE-400, and CWE-915.
9+
* The above queries have been moved to the Security/CWE-915 folder, and assigned the following tags: CWE-078, CWE-079, CWE-094, CWE-400, and CWE-915.
1010
* The query "Type confusion through parameter tampering" (`js/type-confusion-through-parameter-tampering`) now highlights
1111
ineffective prototype pollution checks that can be bypassed by type confusion.

javascript/ql/src/Security/CWE-915/PrototypePollutingAssignment.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
/**
22
* @name Prototype-polluting assignment
33
* @description Modifying an object obtained via a user-controlled property name may
4-
* lead to accidental modification of the built-in Object.prototype,
4+
* lead to accidental mutation of the built-in Object prototype,
55
* and possibly escalate to remote code execution or cross-site scripting.
66
* @kind path-problem
77
* @problem.severity warning
88
* @precision high
99
* @id js/prototype-polluting-assignment
1010
* @tags security
1111
* external/cwe/cwe-078
12+
* external/cwe/cwe-079
1213
* external/cwe/cwe-094
1314
* external/cwe/cwe-400
1415
* external/cwe/cwe-915

javascript/ql/src/Security/CWE-915/PrototypePollutingFunction.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
* @id js/prototype-pollution-utility
99
* @tags security
1010
* external/cwe/cwe-078
11+
* external/cwe/cwe-079
1112
* external/cwe/cwe-094
1213
* external/cwe/cwe-400
1314
* external/cwe/cwe-915

javascript/ql/src/Security/CWE-915/PrototypePollutingMergeCall.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
* @id js/prototype-pollution
1010
* @tags security
1111
* external/cwe/cwe-078
12+
* external/cwe/cwe-079
1213
* external/cwe/cwe-094
1314
* external/cwe/cwe-400
1415
* external/cwe/cwe-915

0 commit comments

Comments
 (0)