Use '// GOOD' and '// BAD' annotations for query diagnostics.

Author: zlaski-semmle

cpp/ql/test/query-tests/Likely Bugs/Memory Management/AllocaInLoop/AllocaInLoop1.cpp

@@ -28,7 +28,7 @@ void foo(const struct vtype* vec, int count) {
 				b1 = new char[w1];
 			} else {
 				// Allocate the buffer on stack
-				b1 = (char*) alloca(w1);  // [FLAG]
+				b1 = (char*) alloca(w1);  // BAD
 			}
 		}
 		memcpy(b1, v, w1);
@@ -52,7 +52,7 @@ void bar(const struct vtype* vec, int count) {
 					b1 = new char[w1];
 				} else {
 					// Allocate the buffer on stack
-					b1 = (char*) alloca(w1);  // [FLAG]
+					b1 = (char*) alloca(w1);  // BAD
 				}
 			}
 		} while (0);
@@ -77,7 +77,7 @@ void baz(const struct vtype* vec, int count) {
 					b1 = new char[w1];
 				} else {
 					// Allocate the buffer on stack
-					b1 = (char*) alloca(w1);  // [FLAG]
+					b1 = (char*) alloca(w1);  // BAD
 				}
 			}
 			memcpy(b1, v, w1);

cpp/ql/test/query-tests/Likely Bugs/Memory Management/AllocaInLoop/AllocaInLoop1ms.cpp

@@ -25,7 +25,7 @@ void foo(const struct vtype* vec, int count) {
 				b1 = new char[w1];
 			} else {
 				// Allocate the buffer on stack
-				b1 = (char*) _alloca(w1);  // [FLAG]
+				b1 = (char*) _alloca(w1);  // BAD
 			}
 		}
 		memcpy(b1, v, w1);
@@ -49,7 +49,7 @@ void bar(const struct vtype* vec, int count) {
 					b1 = new char[w1];
 				} else {
 					// Allocate the buffer on stack
-					b1 = (char*) _malloca(w1);  // [FLAG]
+					b1 = (char*) _malloca(w1);  // BAD
 				}
 			}
 		} while (0);
@@ -76,7 +76,7 @@ void baz(const struct vtype* vec, int count) {
 					b1 = new char[w1];
 				} else {
 					// Allocate the buffer on stack
-					b1 = (char*) _alloca(w1);  // [FLAG]
+					b1 = (char*) _alloca(w1);  // BAD
 				}
 			}
 			memcpy(b1, v, w1);

cpp/ql/test/query-tests/Likely Bugs/Memory Management/AllocaInLoop/AllocaInLoop2.c

@@ -36,7 +36,7 @@ void foo(const struct vtype* vec, int count) {
                 b1 = (char *)malloc(w1);
             } else {
                 // Allocate the buffer on stack
-                b1 = (char*) alloca(w1);  // [FLAG]
+                b1 = (char*) alloca(w1);  // BAD
                 iter = 1;
             }
         }
@@ -61,7 +61,7 @@ void bar(const struct vtype* vec, int count) {
                 b1 = (char *)malloc(w1);
             } else {
                 // Allocate the buffer on stack
-                b1 = (char*) alloca(w1);  // [DO NOT FLAG]
+                b1 = (char*) alloca(w1);  // GOOD
             }
         }
         } while (0);
@@ -76,7 +76,7 @@ void bar(const struct vtype* vec, int count) {
 // case 3: alloca called outside any loops
 void baz(int count) {
 
-	char *buf = (char *)alloca(32); // [DO NOT FLAG]
+	char *buf = (char *)alloca(32); // GOOD
 	sprintf(buf, "Value is %d\n", count);
 	printf("%s", buf);
 }
@@ -94,7 +94,7 @@ void foo_ms(const struct vtype* vec, int count) {
 				(char *)malloc(w1);
 			} else {
 				// Allocate the buffer on stack
-				b1 = (char*) _alloca(w1);  // [DO NOT FLAG]
+				b1 = (char*) _alloca(w1);  // GOOD
 			}
 		}
 		memcpy(b1, v, w1);
@@ -118,7 +118,7 @@ void bar_ms(const struct vtype* vec, int count) {
 					b1 = (char *)malloc(w1);
 				} else {
 					// Allocate the buffer on stack
-					b1 = (char*) _malloca(w1);  // [DO NOT FLAG]
+					b1 = (char*) _malloca(w1);  // GOOD
 				}
 			}
 		} while (0);
@@ -145,7 +145,7 @@ void baz_ms(const struct vtype* vec, int count) {
 					b1 = (char *)malloc(w1);
 				} else {
 					// Allocate the buffer on stack
-					b1 = (char*) _alloca(w1);  // [DO NOT FLAG]
+					b1 = (char*) _alloca(w1);  // GOOD
 				}
 			}
 			memcpy(b1, v, w1);

cpp/ql/test/query-tests/Likely Bugs/Memory Management/AllocaInLoop/AllocaInLoop3.cpp

@@ -15,7 +15,7 @@ void *__builtin_alloca(int sz);
 // case 1: a GNU c/c++ lambda with an alloca in it
 char *foo(int count) {
 	char *buf = ({
-			char *b = (char *)alloca(32); // [DO NOT FLAG]
+			char *b = (char *)alloca(32); // GOOD
 			sprintf(b, "Value is %d\n", count);
 			b;
 		});
@@ -28,7 +28,7 @@ char *bar(int count) {
 	char *buf;
 	do {
 		buf = ({
-				char *b = (char *)alloca(32); // [DO NOT FLAG]
+				char *b = (char *)alloca(32); // GOOD
 				sprintf(b, "Value is %d\n", count);
 				b;
 			});
@@ -42,7 +42,7 @@ char *baz(int count) {
 	char *buf;
 	do {
 		buf = ({
-				char *b = (char *)alloca(32); // [FLAG]
+				char *b = (char *)alloca(32); // BAD
 				sprintf(b, "Value is %d\n", count);
 				b;
 			});