JS: Rename metrics to ResolvableCallX

Author: asger-semmle

javascript/ql/src/meta/analysis-quality/CallGraphQuality.qll

@@ -153,8 +153,8 @@ SourceNode resolvableCallback() {
 /**
  * A call site that can be resolved to a function in the same project.
  */
-class ResolvedCall extends RelevantInvoke {
-  ResolvedCall() {
+class ResolvableCall extends RelevantInvoke {
+  ResolvableCall() {
     FlowSteps::calls(this, _)
     or
     this = resolvableCallback().getAnInvocation()
@@ -166,7 +166,7 @@ class ResolvedCall extends RelevantInvoke {
  */
 class ExternalCall extends RelevantInvoke {
   ExternalCall() {
-    not this instanceof ResolvedCall and // avoid double counting
+    not this instanceof ResolvableCall and // avoid double counting
     (
       // Call to modelled external library
       this = externalNode()
@@ -190,9 +190,9 @@ class ExternalCall extends RelevantInvoke {
 /**
  * A call site that could not be resolved.
  */
-class UnresolvedCall extends RelevantInvoke {
-  UnresolvedCall() {
-    not this instanceof ResolvedCall and
+class UnresolvableCall extends RelevantInvoke {
+  UnresolvableCall() {
+    not this instanceof ResolvableCall and
     not this instanceof ExternalCall
   }
 }

…alysis-quality/ResolvedCallCandidates.ql …ysis-quality/ResolvableCallCandidates.qljavascript/ql/src/meta/analysis-quality/ResolvedCallCandidates.ql renamed to javascript/ql/src/meta/analysis-quality/ResolvableCallCandidates.ql javascript/ql/src/meta/analysis-quality/ResolvedCallCandidates.ql renamed to javascript/ql/src/meta/analysis-quality/ResolvableCallCandidates.ql

@@ -5,7 +5,7 @@
  * @metricType project
  * @metricAggregate sum
  * @tags meta
- * @id js/meta/resolved-call-candidates
+ * @id js/meta/resolvable-call-candidates
  */
 import javascript
 import CallGraphQuality

…ta/analysis-quality/ResolvedCallRatio.ql …/analysis-quality/ResolvableCallRatio.qljavascript/ql/src/meta/analysis-quality/ResolvedCallRatio.ql renamed to javascript/ql/src/meta/analysis-quality/ResolvableCallRatio.ql javascript/ql/src/meta/analysis-quality/ResolvedCallRatio.ql renamed to javascript/ql/src/meta/analysis-quality/ResolvableCallRatio.ql

@@ -1,13 +1,13 @@
 /**
- * @name Resolved call ratio
+ * @name Resolvable call ratio
  * @description The percentage of non-external calls that can be resolved to a target.
  * @kind metric
  * @metricType project
  * @metricAggregate sum min max avg
  * @tags meta
- * @id js/meta/resolved-call-ratio
+ * @id js/meta/resolvable-call-ratio
  */
 import javascript
 import CallGraphQuality
 
-select projectRoot(), 100.0 * count(ResolvedCall call) / (float) count(NonExternalCall call)
+select projectRoot(), 100.0 * count(ResolvableCall call) / (float) count(NonExternalCall call)

…c/meta/analysis-quality/ResolvedCalls.ql …meta/analysis-quality/ResolvableCalls.qljavascript/ql/src/meta/analysis-quality/ResolvedCalls.ql renamed to javascript/ql/src/meta/analysis-quality/ResolvableCalls.ql javascript/ql/src/meta/analysis-quality/ResolvedCalls.ql renamed to javascript/ql/src/meta/analysis-quality/ResolvableCalls.ql

@@ -1,13 +1,13 @@
 /**
- * @name Resolved calls
+ * @name Resolvable calls
  * @description The number of calls that could be resolved to its target.
  * @kind metric
  * @metricType project
  * @metricAggregate sum
  * @tags meta
- * @id js/meta/resolved-calls
+ * @id js/meta/resolvable-calls
  */
 import javascript
 import CallGraphQuality
 
-select projectRoot(), count(ResolvedCall call)
+select projectRoot(), count(ResolvableCall call)

…meta/analysis-quality/UnresolvedCalls.ql …ta/analysis-quality/UnresolvableCalls.qljavascript/ql/src/meta/analysis-quality/UnresolvedCalls.ql renamed to javascript/ql/src/meta/analysis-quality/UnresolvableCalls.ql javascript/ql/src/meta/analysis-quality/UnresolvedCalls.ql renamed to javascript/ql/src/meta/analysis-quality/UnresolvableCalls.ql

@@ -1,13 +1,13 @@
 /**
- * @name Unresolved calls
- * @description The number of calls that could not be resolved to its target.
+ * @name Unresolvable calls
+ * @description The number of calls that could not be resolved to a target.
  * @kind metric
  * @metricType project
  * @metricAggregate sum
  * @tags meta
- * @id js/meta/unresolved-calls
+ * @id js/meta/unresolvable-calls
  */
 import javascript
 import CallGraphQuality
 
-select projectRoot(), count(UnresolvedCall call)
+select projectRoot(), count(UnresolvableCall call)