Skip to content

Commit 0df7c29

Browse files
pallsamavgrlmchammer01
authored
Updating new end of support dates for GHES 3.14, 3.15, 3.16 and 3.17. (#57409)
Co-authored-by: Vanessa <vgrl@github.com> Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
1 parent 8c960d0 commit 0df7c29

File tree

3 files changed

+8
-20
lines changed

3 files changed

+8
-20
lines changed

src/archives/tests/deprecated-enterprise-versions.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,7 @@ describe('recently deprecated redirects', () => {
138138
})
139139

140140
describe('deprecation banner', () => {
141-
// The deprecation banner is temporarily hidden for supported versions
142-
test.skip('renders a deprecation warning banner on oldest supported Enterprise version', async () => {
141+
test('renders a deprecation warning banner on oldest supported Enterprise version', async () => {
143142
const { $ } = await getDOM(`/en/enterprise/${enterpriseServerReleases.oldestSupported}`)
144143
expect($('[data-testid=deprecation-banner]').length).toBe(1)
145144
})
@@ -154,8 +153,7 @@ describe('deprecation banner', () => {
154153
expect($('[data-testid=deprecation-banner] b').text().endsWith('discontinued on .')).toBe(false)
155154
})
156155

157-
// The deprecation banner is temporarily hidden for supported versions
158-
test.skip('deprecation warning banner includes the right text depending on the date', async () => {
156+
test('deprecation warning banner includes the right text depending on the date', async () => {
159157
const { $ } = await getDOM(`/en/enterprise/${enterpriseServerReleases.oldestSupported}`)
160158
const expectedString = enterpriseServerReleases.isOldestReleaseDeprecated
161159
? 'was discontinued'

src/ghes-releases/lib/enterprise-dates.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -229,31 +229,31 @@
229229
},
230230
"3.14": {
231231
"releaseDate": "2024-08-06",
232-
"deprecationDate": "2025-08-27",
232+
"deprecationDate": "2026-03-17",
233233
"releaseCandidateDate": "2024-08-06",
234234
"generalAvailabilityDate": "2024-08-27"
235235
},
236236
"3.15": {
237237
"releaseDate": "2024-11-12",
238-
"deprecationDate": "2025-12-19",
238+
"deprecationDate": "2026-03-17",
239239
"releaseCandidateDate": "2024-11-12",
240240
"generalAvailabilityDate": "2024-12-03"
241241
},
242242
"3.16": {
243243
"releaseDate": "2025-02-25",
244-
"deprecationDate": "2026-03-11",
244+
"deprecationDate": "2026-06-02",
245245
"releaseCandidateDate": "2025-02-25",
246246
"generalAvailabilityDate": "2025-03-11"
247247
},
248248
"3.17": {
249249
"releaseDate": "2025-05-13",
250-
"deprecationDate": "2026-06-03",
250+
"deprecationDate": "2026-08-25",
251251
"releaseCandidateDate": "2025-05-13",
252252
"generalAvailabilityDate": "2025-06-03"
253253
},
254254
"3.18": {
255255
"releaseDate": "2025-08-05",
256-
"deprecationDate": "2026-08-26",
256+
"deprecationDate": "2026-08-25",
257257
"releaseCandidateDate": "2025-08-05",
258258
"generalAvailabilityDate": "2025-08-26"
259259
},
@@ -287,4 +287,4 @@
287287
"releaseCandidateDate": "2026-11-10",
288288
"generalAvailabilityDate": "2026-12-08"
289289
}
290-
}
290+
}

src/versions/components/DeprecationBanner.tsx

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@ import cx from 'classnames'
66

77
import styles from './DeprecationBanner.module.scss'
88

9-
// GHES deprecation dates are being extended while
10-
// performance issues are being addressed in versions >= 3.15.
11-
// This banner should remain hidden for the supported versions (>=3.14) until
12-
// new deprecation dates are announced.
13-
const DEPRECATION_BANNER_EXCEPTIONS = ['3.14']
14-
159
export const DeprecationBanner = () => {
1610
const { data, enterpriseServerReleases } = useMainContext()
1711
const { currentVersion } = useVersion()
@@ -29,10 +23,6 @@ export const DeprecationBanner = () => {
2923
? enterpriseDeprecation.version_was_deprecated
3024
: enterpriseDeprecation.version_will_be_deprecated
3125

32-
if (DEPRECATION_BANNER_EXCEPTIONS.some((version) => currentVersion.includes(version))) {
33-
return null
34-
}
35-
3626
return (
3727
<div
3828
data-testid="deprecation-banner"

0 commit comments

Comments
 (0)