Skip to content

Commit 30ae562

Browse files
committed
fixing name
1 parent 5d8561f commit 30ae562

File tree

6 files changed

+26
-27
lines changed

6 files changed

+26
-27
lines changed

cmd/github-mcp-server/main.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ var (
8383
LogFilePath: viper.GetString("log-file"),
8484
ContentWindowSize: viper.GetInt("content-window-size"),
8585
LockdownMode: viper.GetBool("lockdown-mode"),
86-
Experimental: viper.GetBool("experimental"),
86+
InsiderMode: viper.GetBool("insider-mode"),
8787
RepoAccessCacheTTL: &ttl,
8888
}
8989
return ghmcp.RunStdioServer(stdioServerConfig)
@@ -109,7 +109,7 @@ func init() {
109109
rootCmd.PersistentFlags().String("gh-host", "", "Specify the GitHub hostname (for GitHub Enterprise etc.)")
110110
rootCmd.PersistentFlags().Int("content-window-size", 5000, "Specify the content window size")
111111
rootCmd.PersistentFlags().Bool("lockdown-mode", false, "Enable lockdown mode")
112-
rootCmd.PersistentFlags().Bool("experimental", false, "Enable experimental features")
112+
rootCmd.PersistentFlags().Bool("insider-mode", false, "Enable insider features")
113113
rootCmd.PersistentFlags().Duration("repo-access-cache-ttl", 5*time.Minute, "Override the repo access cache TTL (e.g. 1m, 0s to disable)")
114114

115115
// Bind flag to viper
@@ -124,7 +124,7 @@ func init() {
124124
_ = viper.BindPFlag("host", rootCmd.PersistentFlags().Lookup("gh-host"))
125125
_ = viper.BindPFlag("content-window-size", rootCmd.PersistentFlags().Lookup("content-window-size"))
126126
_ = viper.BindPFlag("lockdown-mode", rootCmd.PersistentFlags().Lookup("lockdown-mode"))
127-
_ = viper.BindPFlag("experimental", rootCmd.PersistentFlags().Lookup("experimental"))
127+
_ = viper.BindPFlag("insider-mode", rootCmd.PersistentFlags().Lookup("insider-mode"))
128128
_ = viper.BindPFlag("repo-access-cache-ttl", rootCmd.PersistentFlags().Lookup("repo-access-cache-ttl"))
129129

130130
// Add subcommands

internal/ghmcp/server.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ type MCPServerConfig struct {
6464
// LockdownMode indicates if we should enable lockdown mode
6565
LockdownMode bool
6666

67-
// Experimental indicates if we should enable experimental features
68-
Experimental bool
67+
// Insider indicates if we should enable experimental features
68+
InsiderMode bool
6969

7070
// Logger is used for logging within the server
7171
Logger *slog.Logger
@@ -213,7 +213,7 @@ func NewMCPServer(cfg MCPServerConfig) (*mcp.Server, error) {
213213
cfg.Translator,
214214
github.FeatureFlags{
215215
LockdownMode: cfg.LockdownMode,
216-
Experimental: cfg.Experimental,
216+
InsiderMode: cfg.InsiderMode,
217217
},
218218
cfg.ContentWindowSize,
219219
featureChecker,
@@ -332,8 +332,8 @@ type StdioServerConfig struct {
332332
// LockdownMode indicates if we should enable lockdown mode
333333
LockdownMode bool
334334

335-
// Experimental indicates if we should enable experimental features
336-
Experimental bool
335+
// InsiderMode indicates if we should enable experimental features
336+
InsiderMode bool
337337

338338
// RepoAccessCacheTTL overrides the default TTL for repository access cache entries.
339339
RepoAccessCacheTTL *time.Duration
@@ -391,7 +391,7 @@ func RunStdioServer(cfg StdioServerConfig) error {
391391
Translator: t,
392392
ContentWindowSize: cfg.ContentWindowSize,
393393
LockdownMode: cfg.LockdownMode,
394-
Experimental: cfg.Experimental,
394+
InsiderMode: cfg.InsiderMode,
395395
Logger: logger,
396396
RepoAccessTTL: cfg.RepoAccessCacheTTL,
397397
TokenScopes: tokenScopes,

internal/ghmcp/server_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestNewMCPServer_CreatesSuccessfully(t *testing.T) {
2323
Translator: translations.NullTranslationHelper,
2424
ContentWindowSize: 5000,
2525
LockdownMode: false,
26-
Experimental: false,
26+
InsiderMode: false,
2727
}
2828

2929
// Create the server

pkg/github/feature_flags.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ package github
33
// FeatureFlags defines runtime feature toggles that adjust tool behavior.
44
type FeatureFlags struct {
55
LockdownMode bool
6-
Experimental bool
6+
InsiderMode bool
77
}

pkg/github/feature_flags_test.go

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ import (
1515
"github.com/github/github-mcp-server/pkg/utils"
1616
)
1717

18-
// RemoteMCPExperimental is a long-lived feature flag for experimental remote MCP features.
19-
// This flag enables experimental behaviors in tools that are being tested for remote server deployment.
18+
// RemoteMCPEnthusiasticGreeting is a dummy test feature flag .
2019
const RemoteMCPEnthusiasticGreeting = "remote_mcp_enthusiastic_greeting"
2120

2221
// FeatureChecker is an interface for checking if a feature flag is enabled.
@@ -46,7 +45,7 @@ func HelloWorldTool(t translations.TranslationHelperFunc) inventory.ServerTool {
4645
if deps.IsFeatureEnabled(ctx, RemoteMCPEnthusiasticGreeting) {
4746
greeting += " Welcome to the future of MCP! 🎉"
4847
}
49-
if deps.GetFlags().Experimental {
48+
if deps.GetFlags().InsiderMode {
5049
greeting += " Experimental features are enabled! 🚀"
5150
}
5251

@@ -114,10 +113,10 @@ func TestHelloWorld_ConditionalBehavior_Featureflag(t *testing.T) {
114113
// Call the handler with deps in context
115114
ctx := ContextWithDeps(context.Background(), deps)
116115
result, err := handler(ctx, &mcp.CallToolRequest{
117-
Params: &mcp.CallToolParamsRaw{
118-
Arguments: json.RawMessage(`{}`),
119-
},
120-
})
116+
Params: &mcp.CallToolParamsRaw{
117+
Arguments: json.RawMessage(`{}`),
118+
},
119+
})
121120
require.NoError(t, err)
122121
require.NotNil(t, result)
123122
require.Len(t, result.Content, 1)
@@ -141,17 +140,17 @@ func TestHelloWorld_ConditionalBehavior_Config(t *testing.T) {
141140

142141
tests := []struct {
143142
name string
144-
experimental bool
143+
insiderMode bool
145144
expectedGreeting string
146145
}{
147146
{
148147
name: "Experimental disabled - default greeting",
149-
experimental: false,
148+
insiderMode: false,
150149
expectedGreeting: "Hello, world!",
151150
},
152151
{
153152
name: "Experimental enabled - experimental greeting",
154-
experimental: true,
153+
insiderMode: true,
155154
expectedGreeting: "Hello, world! Experimental features are enabled! 🚀",
156155
},
157156
}
@@ -164,7 +163,7 @@ func TestHelloWorld_ConditionalBehavior_Config(t *testing.T) {
164163
deps := NewBaseDeps(
165164
nil, nil, nil, nil,
166165
translations.NullTranslationHelper,
167-
FeatureFlags{Experimental: tt.experimental},
166+
FeatureFlags{InsiderMode: tt.insiderMode},
168167
0,
169168
nil,
170169
)
@@ -176,10 +175,10 @@ func TestHelloWorld_ConditionalBehavior_Config(t *testing.T) {
176175
// Call the handler with deps in context
177176
ctx := ContextWithDeps(context.Background(), deps)
178177
result, err := handler(ctx, &mcp.CallToolRequest{
179-
Params: &mcp.CallToolParamsRaw{
180-
Arguments: json.RawMessage(`{}`),
181-
},
182-
})
178+
Params: &mcp.CallToolParamsRaw{
179+
Arguments: json.RawMessage(`{}`),
180+
},
181+
})
183182
require.NoError(t, err)
184183
require.NotNil(t, result)
185184
require.Len(t, result.Content, 1)

pkg/github/server_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func stubRepoAccessCache(client *githubv4.Client, ttl time.Duration) *lockdown.R
8484
func stubFeatureFlags(enabledFlags map[string]bool) FeatureFlags {
8585
return FeatureFlags{
8686
LockdownMode: enabledFlags["lockdown-mode"],
87-
Experimental: enabledFlags["experimental"],
87+
InsiderMode: enabledFlags["insider-mode"],
8888
}
8989
}
9090

0 commit comments

Comments
 (0)