Skip to content

Commit d3ff0a2

Browse files
fix: address review feedback
- Document GraphQLFeaturesTransport is for library consumers - Convert githubv4.Int/String to native Go types in result map - Remove misleading log comment since tool handlers lack logger access
1 parent 92d8d51 commit d3ff0a2

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

pkg/github/issues.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1927,7 +1927,7 @@ func AssignCopilotToIssue(t translations.TranslationHelperFunc) inventory.Server
19271927

19281928
pr, err := findLinkedCopilotPR(ctx, client, params.Owner, params.Repo, int(params.IssueNumber), assignmentTime)
19291929
if err != nil {
1930-
// Log but don't fail - polling errors are non-fatal
1930+
// Polling errors are non-fatal, continue to next attempt
19311931
continue
19321932
}
19331933
if pr != nil {
@@ -1939,8 +1939,8 @@ func AssignCopilotToIssue(t translations.TranslationHelperFunc) inventory.Server
19391939
// Build the result
19401940
result := map[string]any{
19411941
"message": "successfully assigned copilot to issue",
1942-
"issue_number": updateIssueMutation.UpdateIssue.Issue.Number,
1943-
"issue_url": updateIssueMutation.UpdateIssue.Issue.URL,
1942+
"issue_number": int(updateIssueMutation.UpdateIssue.Issue.Number),
1943+
"issue_url": string(updateIssueMutation.UpdateIssue.Issue.URL),
19441944
"owner": params.Owner,
19451945
"repo": params.Repo,
19461946
}

pkg/github/transport.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ import (
99
// header to requests based on context values. This is required for using
1010
// non-GA GraphQL API features like the agent assignment API.
1111
//
12+
// This transport is exported for use by library consumers who need to build
13+
// their own HTTP clients with GraphQL feature flag support. The MCP server
14+
// itself uses an inline implementation in its transport stack.
15+
//
1216
// Usage:
1317
//
1418
// httpClient := &http.Client{

0 commit comments

Comments
 (0)