Fix cases of @typescript-eslint/no-for-in-array

Author: robertbrignull

extensions/ql-vscode/gulpfile.ts/textmate.ts

@@ -66,8 +66,7 @@ function getNodeMatchText(rule: Pattern): string {
   } else if (rule.patterns !== undefined) {
     const patterns: string[] = [];
     // For a list of patterns, use the disjunction of those patterns.
-    for (const patternIndex in rule.patterns) {
-      const pattern = rule.patterns[patternIndex];
+    for (const pattern of rule.patterns) {
       if (pattern.include !== null) {
         patterns.push(`(?${pattern.include})`);
       }
@@ -180,11 +179,11 @@ function expandPatternMatchProperties<T>(
     const patterns: string[] = Array.isArray(pattern) ? pattern : [pattern];
     rule[key] = patterns.map((p) => `((?${p}))`).join("|") as T;
     const captures: Pattern["captures"] = {};
-    for (const patternIndex in patterns) {
-      captures[(Number(patternIndex) + 1).toString()] = {
+    for (const [captureIndex, capture] of patterns.entries()) {
+      captures[(Number(captureIndex) + 1).toString()] = {
         patterns: [
           {
-            include: patterns[patternIndex],
+            include: capture,
           },
         ],
       };