Run eslint --fix

Author: robertbrignull

extensions/ql-vscode/src/codeql-cli/cli.ts

@@ -1834,7 +1834,7 @@ export function spawnServer(
   }
 
   let lastStdout: string | Buffer | undefined = undefined;
-  child.stdout!.on("data", (data) => {
+  child.stdout.on("data", (data) => {
     lastStdout = data;
   });
   // Set up event listeners.
@@ -1853,9 +1853,9 @@ export function spawnServer(
       void logger.log(`Last stdout was "${lastStdout.toString()}"`);
     }
   });
-  child.stderr!.on("data", stderrListener);
+  child.stderr.on("data", stderrListener);
   if (stdoutListener !== undefined) {
-    child.stdout!.on("data", stdoutListener);
+    child.stdout.on("data", stdoutListener);
   }
 
   if (progressReporter !== undefined) {

extensions/ql-vscode/src/codeql-cli/distribution.ts

@@ -346,9 +346,9 @@ class ExtensionSpecificDistributionManager {
               "distributionFolderIndex",
               0,
             ) ?? 0,
-          release: (this.extensionContext.globalState.get(
-            "distributionRelease",
-          ) ?? null) as Release | null,
+          release:
+            this.extensionContext.globalState.get("distributionRelease") ??
+            null,
         };
 
         // This may result in a race condition, but when this happens both processes should write the same file.

extensions/ql-vscode/src/common/vscode/selection-commands.ts

@@ -18,7 +18,7 @@ type SelectionCommand<T extends NotArray> = CreateSupertypeOf<
   TreeViewContextMultiSelectionCommandFunction<T> &
     TreeViewContextSingleSelectionCommandFunction<T> &
     ExplorerSelectionCommandFunction<T>,
-  (singleItem: T, multiSelect?: T[] | undefined) => Promise<void>
+  (singleItem: T, multiSelect?: T[]) => Promise<void>
 >;
 
 export function createSingleSelectionCommand<T extends NotArray>(

extensions/ql-vscode/src/config.ts

@@ -406,7 +406,7 @@ export class QueryServerConfigListener
   ): Promise<QueryServerConfigListener> {
     const codeQlPath =
       await distributionManager.getCodeQlPathWithoutVersionCheck();
-    const config = new QueryServerConfigListener(codeQlPath!);
+    const config = new QueryServerConfigListener(codeQlPath);
     if (distributionManager.onDidChangeDistribution) {
       config.push(
         distributionManager.onDidChangeDistribution(async () => {

extensions/ql-vscode/src/language-support/contextual/template-provider.ts

@@ -133,7 +133,7 @@ export class TemplateQueryReferenceProvider implements ReferenceProvider {
 
     const locLinks: Location[] = [];
     for (const link of fileLinks) {
-      if (link.targetRange!.contains(position)) {
+      if (link.targetRange.contains(position)) {
         locLinks.push({
           range: link.originSelectionRange!,
           uri: link.originUri,

extensions/ql-vscode/src/language-support/language-client.ts

@@ -79,7 +79,7 @@ async function spawnLanguageServer(
           languageServerLogger.log(data.toString(), { trailingNewline: false }),
         progressReporter,
       );
-      return { writer: child.stdin!, reader: child.stdout! };
+      return { writer: child.stdin, reader: child.stdout };
     },
   );
 }

extensions/ql-vscode/src/local-queries/local-queries.ts

@@ -56,7 +56,8 @@ import { LocalQueryRun } from "./local-query-run";
 import { createMultiSelectionCommand } from "../common/vscode/selection-commands";
 import { findLanguage } from "../codeql-cli/query-language";
 import type { QueryTreeViewItem } from "../queries-panel/query-tree-view-item";
-import { QueryLanguage, tryGetQueryLanguage } from "../common/query-language";
+import type { QueryLanguage } from "../common/query-language";
+import { tryGetQueryLanguage } from "../common/query-language";
 import type { LanguageContextStore } from "../language-context-store";
 import type { ExtensionApp } from "../common/vscode/extension-app";
 import type { DatabaseFetcher } from "../databases/database-fetcher";
@@ -184,7 +185,7 @@ export class LocalQueries extends DisposableObject {
   private async runQueries(fileURIs: Uri[]): Promise<void> {
     await withProgress(
       async (progress, token) => {
-        const maxQueryCount = MAX_QUERIES.getValue() as number;
+        const maxQueryCount = MAX_QUERIES.getValue();
         const [files, dirFound] = await gatherQlFiles(
           fileURIs.map((uri) => uri.fsPath),
         );

extensions/ql-vscode/src/local-queries/query-contents.ts

@@ -15,7 +15,7 @@ import { dbSchemeToLanguage } from "../common/query-language";
  */
 export function getInitialQueryContents(language: string, dbscheme: string) {
   if (!language) {
-    const dbschemeBase = basename(dbscheme) as keyof typeof dbSchemeToLanguage;
+    const dbschemeBase = basename(dbscheme);
     language = dbSchemeToLanguage[dbschemeBase];
   }
 

extensions/ql-vscode/src/log-insights/join-order.ts

@@ -202,7 +202,7 @@ class JoinOrderScanner {
           const metric = computeJoinOrderBadness(
             maxTupleCount,
             maxDependentPredicateSize,
-            resultSize!,
+            resultSize,
           );
           if (metric >= this.warningThreshold) {
             const message = `'${event.predicateName}@${event.raHash.substring(

extensions/ql-vscode/src/model-editor/library.ts

@@ -32,7 +32,7 @@ export function parseLibraryFilename(filename: string): Library {
   semverRegex.lastIndex = 0;
 
   // Find the last occurence of the regex within the library name
-  // eslint-disable-next-line no-constant-condition
+
   while (true) {
     const currentMatch = semverRegex.exec(libraryName);
     if (currentMatch === null) {