More eslint cleanup

Author: JustinGrote

eslint.config.mjs

@@ -10,13 +10,14 @@ export default tseslint.config(
   // Ignores formatting rules that will be handled by Prettier
   eslintConfigPrettier,
   {
-    files: [
-      '**/*.ts',
-      '**/*.js',
-      '**/*.mjs'
-    ],
+    name: "globalignores",
     ignores: [
-      '**/node_modules/**'
+      '**/node_modules/**',
+      'jest.config.js',
+      'src/external/**',
+      '.vscode-test-web/**',
+      'dist/**',
+      'out/**'
     ]
   }
 );

src/commands/openWorkflowFile.ts

@@ -22,7 +22,7 @@ export function registerOpenWorkflowFile(context: vscode.ExtensionContext) {
             const textDocument = await vscode.workspace.openTextDocument(fileUri);
             await vscode.window.showTextDocument(textDocument);
             return;
-          } catch (e) {
+          } catch {
             // Ignore error and show error message below
           }
         }

src/treeViews/settings/repoVariablesNode.ts

@@ -16,12 +16,14 @@ export class RepoVariablesNode extends vscode.TreeItem {
     let variables: VariableNode[] = [];
     try {
       variables = await this.gitHubRepoContext.client.paginate(
+        // @ts-expect-error FIXME: Type error after newer rules available. This will be fixed in octokit bump
         this.gitHubRepoContext.client.actions.listRepoVariables,
         {
           owner: this.gitHubRepoContext.owner,
           repo: this.gitHubRepoContext.name,
           per_page: 100
         },
+        // @ts-expect-error FIXME: Type error after newer rules available. This will be fixed in octokit bump
         response => response.data.map(s => new VariableNode(this.gitHubRepoContext, s))
       );
     } catch (e) {

src/workflow/workflow.ts

@@ -42,7 +42,7 @@ export async function getContextStringForWorkflow(workflowUri: vscode.Uri): Prom
 
       return context.join("");
     }
-  } catch (e) {
+  } catch {
     // Ignore
   }