[4.5.0 bug] ADS_VERSION is no longer supported!

[vtad4f]

2 issues:

• When I shallow-clone your repo as a submodule, I'm not able to rely on a git tag because the git tag may not exist at the current hash. I was setting ADS_VERSION, but now that's no longer an option since Versioning.cmake only checks git tag.
• Even if I manually set a git tag via cmake as a hack, it still fails because in Versioning.cmake you're using ${CMAKE_SOURCE_DIR} instead of ${CMAKE_CURRENT_LIST_DIR}. CMAKE_SOURCE_DIR is the value of my root repo's directory (not your qt ads submodule). In contrast, CMAKE_CURRENT_LIST_DIR is the path to the Versioning.cmake parent dir.

Oh, and the symptom is a build failure. The [...]_version.rc file has invalid syntax:

VS_VERSION_INFO VERSIONINFO
 FILEVERSION     ,,,0
 PRODUCTVERSION  ,,,0

If the cmake doesn't change, my only viable hack is to have cmake edit this rc file after your cmake runs and find/replace ,,,0 with the correct version.

[githubuser0xFFFF]

Thank you for reporting this issue. Are you able to provide a pull request to fix this?