Initialize Tests

Author: Emmanouil Konstantinidis

package.json

@@ -10,7 +10,45 @@
     "watch": "grunt build && npm build && npm run watch-js | grunt watch",
     "start": "electron .",
     "dist": "rm -rf Gitify.app/ && electron-packager . Gitify --platform=darwin --arch=x64 --version=0.27.1 --icon=images/app-icon.icns --prune --ignore=src",
-    "test": "jsxhint --reporter node_modules/jshint-stylish/stylish.js 'src/**/*.js', 'index.js' --exclude 'Gruntfile.js'"
+    "test": "jsxhint --reporter node_modules/jshint-stylish/stylish.js 'src/**/*.js', 'index.js' --exclude 'Gruntfile.js' && jscs 'src/js/' && jest"
+  },
+  "jscsConfig": {
+    "esprima": "esprima-fb",
+    "disallowMultipleVarDecl": "exceptUndefined",
+    "validateQuoteMarks": {
+      "mark": "'",
+      "escape": false
+    },
+    "validateParameterSeparator": ", ",
+    "validateIndentation": 2,
+    "requireSpacesInFunction": {
+      "beforeOpeningRoundBrace": true,
+      "beforeOpeningCurlyBrace": true
+    },
+    "requireSpacesInConditionalExpression": {
+      "afterTest": true,
+      "beforeConsequent": true,
+      "afterConsequent": true,
+      "beforeAlternate": true
+    },
+    "disallowTrailingWhitespace": true,
+    "maximumLineLength": 100,
+    "requireCurlyBraces": true,
+    "disallowMixedSpacesAndTabs": true,
+    "requireSpaceBeforeBinaryOperators": true,
+    "safeContextKeyword": [
+      "self"
+    ],
+    "disallowMultipleLineBreaks": true,
+    "disallowMultipleLineStrings": true,
+    "disallowSpaceAfterObjectKeys": true,
+    "disallowNewlineBeforeBlockStatements": true,
+    "disallowTrailingComma": true,
+    "requireCommaBeforeLineBreak": true,
+    "requireSpaceBetweenArguments": true,
+    "requireSpaceBeforeBlockStatements": true,
+    "requireSpaceBeforeObjectValues": true,
+    "requireSpacesInForStatement": true
   },
   "repository": {
     "type": "git",
@@ -46,11 +84,14 @@
   "devDependencies": {
     "electron-packager": "=4.1.2",
     "electron-prebuilt": "=0.27.1",
+    "esprima-fb": "^15001.1.0-dev-harmony-fb",
     "grunt": "=0.4.5",
     "grunt-contrib-clean": "=0.6.0",
     "grunt-contrib-copy": "=0.8.0",
     "grunt-contrib-less": "=1.0.1",
     "grunt-contrib-watch": "=0.6.1",
+    "jest-cli": "=0.4.5",
+    "jscs": "^1.13.1",
     "jshint-stylish": "=1.0.2",
     "jsxhint": "=0.15.0",
     "less": "=2.5.1"

src/js/__tests__/basic.js

@@ -0,0 +1,7 @@
+/* global describe, it, expect */
+
+describe('basic', function () {
+  it('adds two and two and gets four', function () {
+    expect(2 + 2).toBe(4);
+  });
+});

src/js/actions/actions.js

@@ -4,7 +4,7 @@ var Actions = Reflux.createActions({
 
   'login': {},
   'logout': {},
-  'getNotifications': {asyncResult: true},
+  'getNotifications': {asyncResult: true}
 
 });
 

src/js/app.js

@@ -16,7 +16,7 @@ var App = React.createClass({
   statics: {
     willTransitionTo: function (transition) {
       if (transition.path !== '/login' && !AuthStore.authStatus()) {
-        console.log("Not logged in. Redirecting to login.");
+        console.log('Not logged in. Redirecting to login.');
         transition.redirect('login', {});
       }
     }

src/js/components/footer.js

@@ -12,7 +12,11 @@ var Footer = React.createClass({
     return (
       <div className='container-fluid footer'>
         <div className='row'>
-          <div className='col-xs-12 right' onClick={this.openRepoBrowser}>Fork me on <span className="octicon octicon-mark-github"/></div>
+          <div
+            className='col-xs-12 right'
+            onClick={this.openRepoBrowser}>
+              Fork me on <span className="octicon octicon-mark-github"/>
+            </div>
         </div>
       </div>
     );

src/js/components/login.js

@@ -19,22 +19,27 @@ var Login = React.createClass({
 
     // Start Login
     var options = {
-        client_id: '27a352516d3341cee376',
-        client_secret: '626a199b0656c55b2cbf3a3199e573ce17f549bc',
-        scope: ["user:email", "notifications"]
+      client_id: '27a352516d3341cee376',
+      client_secret: '626a199b0656c55b2cbf3a3199e573ce17f549bc',
+      scope: ['user:email', 'notifications']
     };
 
     //Build the OAuth consent page URL
-    var authWindow = new BrowserWindow({ width: 800, height: 600, show: true, 'node-integration': false });
+    var authWindow = new BrowserWindow({
+      width: 800,
+      height: 600,
+      show: true,
+      'node-integration': false
+    });
     var githubUrl = 'https://github.com/login/oauth/authorize?';
     var authUrl = githubUrl + 'client_id=' + options.client_id + '&scope=' + options.scope;
     authWindow.loadUrl(authUrl);
 
-    authWindow.webContents.on('did-get-redirect-request', function(event, oldUrl, newUrl) {
+    authWindow.webContents.on('did-get-redirect-request', function (event, oldUrl, newUrl) {
 
-      var raw_code = /code=([^&]*)/.exec(newUrl) || null,
-        code = (raw_code && raw_code.length > 1) ? raw_code[1] : null,
-        error = /\?error=(.+)$/.exec(newUrl);
+      var raw_code = /code=([^&]*)/.exec(newUrl) || null;
+      var code = (raw_code && raw_code.length > 1) ? raw_code[1] : null;
+      var error = /\?error=(.+)$/.exec(newUrl);
 
       if (code || error) {
         // Close the browser if code found or error
@@ -45,14 +50,14 @@ var Login = React.createClass({
       if (code) {
         self.requestGithubToken(options, code);
       } else if (error) {
-        alert("Oops! Something went wrong and we couldn't log you in using Github. Please try again.");
+        alert('Oops! Something went wrong and we couldn\'t log you in using Github. Please try again.');
       }
 
     });
 
     // If "Done" button is pressed, hide "Loading"
     authWindow.on('close', function() {
-        authWindow = null;
+      authWindow = null;
     }, false);
 
   },

src/js/components/navigation.js

@@ -27,7 +27,7 @@ var Navigation = React.createClass({
     var self = this;
     var iFrequency = 60000;
     var myInterval = 0;
-    if (myInterval > 0) clearInterval(myInterval);
+    if (myInterval > 0) { clearInterval(myInterval); }
     setInterval( function () {
       self.refreshNotifications();
     }, iFrequency );

src/js/stores/notifications.js

@@ -40,12 +40,12 @@ var NotificationsStore = Reflux.createStore({
   },
 
   onGetNotificationsCompleted: function (notifications) {
-    var groupedNotifications = _.groupBy(notifications, function(object){
+    var groupedNotifications = _.groupBy(notifications, function (object){
       return object.repository.full_name;
     });
 
-    var array= [];
-    _.map(groupedNotifications, function(obj, i) {
+    var array = [];
+    _.map(groupedNotifications, function (obj, i) {
       array.push(obj);
     });
 
@@ -54,7 +54,7 @@ var NotificationsStore = Reflux.createStore({
   },
 
   onGetNotificationsFailed: function (error) {
-    console.log("Errored." + error);
+    console.log('Errored.' + error);
   }
 
 });