looks like now the toggling works as expected

Author: aiday-mar

src/vs/workbench/contrib/inlineChat/browser/inlineChatActions.ts

@@ -12,7 +12,7 @@ import { EditorContextKeys } from 'vs/editor/common/editorContextKeys';
 import { InlineChatController, InlineChatRunOptions } from 'vs/workbench/contrib/inlineChat/browser/inlineChatController';
 import { CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_HAS_ACTIVE_REQUEST, CTX_INLINE_CHAT_HAS_PROVIDER, CTX_INLINE_CHAT_INNER_CURSOR_FIRST, CTX_INLINE_CHAT_INNER_CURSOR_LAST, CTX_INLINE_CHAT_EMPTY, CTX_INLINE_CHAT_OUTER_CURSOR_POSITION, CTX_INLINE_CHAT_VISIBLE, MENU_INLINE_CHAT_WIDGET, MENU_INLINE_CHAT_WIDGET_DISCARD, MENU_INLINE_CHAT_WIDGET_STATUS, CTX_INLINE_CHAT_LAST_FEEDBACK, CTX_INLINE_CHAT_SHOWING_DIFF, CTX_INLINE_CHAT_EDIT_MODE, EditMode, CTX_INLINE_CHAT_LAST_RESPONSE_TYPE, MENU_INLINE_CHAT_WIDGET_MARKDOWN_MESSAGE, CTX_INLINE_CHAT_MESSAGE_CROP_STATE, CTX_INLINE_CHAT_DOCUMENT_CHANGED, CTX_INLINE_CHAT_DID_EDIT, CTX_INLINE_CHAT_HAS_STASHED_SESSION, MENU_INLINE_CHAT_WIDGET_FEEDBACK, ACTION_ACCEPT_CHANGES, ACTION_REGENERATE_RESPONSE, InlineChatResponseType, CTX_INLINE_CHAT_RESPONSE_TYPES, InlineChateResponseTypes, ACTION_VIEW_IN_CHAT, CTX_INLINE_CHAT_USER_DID_EDIT, MENU_INLINE_CHAT_WIDGET_TOGGLE } from 'vs/workbench/contrib/inlineChat/common/inlineChat';
 import { localize } from 'vs/nls';
-import { IAction2Options, MenuRegistry } from 'vs/platform/actions/common/actions';
+import { IAction2Options, MenuId, MenuRegistry } from 'vs/platform/actions/common/actions';
 import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService';
 import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';
 import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';
@@ -452,25 +452,29 @@ export class ToggleInlineDiff extends AbstractInlineChatAction {
 	constructor() {
 		super({
 			id: 'inlineChat.toggleDiff',
-			title: localize('toggleDiff', 'Toggle Diff'),
-			icon: Codicon.diff,
-			precondition: ContextKeyExpr.and(CTX_INLINE_CHAT_VISIBLE),
+			title: {
+				value: localize('toggleDiff', 'Toggle Diff'),
+				mnemonicTitle: localize({ key: 'miToggleDiff', comment: ['&& denotes a mnemonic'] }, "&&Toggle Diff"),
+				original: 'Toggle Diff',
+			},
 			category: Categories.View,
 			toggled: {
-				condition: CTX_INLINE_CHAT_SHOWING_DIFF,
-				title: localize('toggleDiff2', "Show Inline Diff")
+				condition: ContextKeyExpr.equals('config.inlineChat.showDiff', true),
+				title: localize('toggleDiff2', "Toggle Diff"),
+				mnemonicTitle: localize({ key: 'miToggleDiff2', comment: ['&& denotes a mnemonic'] }, "&&Toggle Diff")
 			},
-			menu: {
-				id: MENU_INLINE_CHAT_WIDGET_TOGGLE,
-				when: CTX_INLINE_CHAT_EDIT_MODE.notEqualsTo(EditMode.Preview)
-			}
+			menu: [
+				{ id: MenuId.CommandPalette },
+				{ id: MENU_INLINE_CHAT_WIDGET_TOGGLE }
+			]
 		});
 	}
 
 	override runInlineChatCommand(accessor: ServicesAccessor, _ctrl: InlineChatController): void {
 		const configurationService = accessor.get(IConfigurationService);
 		const newValue = !configurationService.getValue('inlineChat.showDiff');
 		configurationService.updateValue('inlineChat.showDiff', newValue);
+		console.log('newValue : ', newValue);
 	}
 }