feat: add known github plugins

christophwitzko · christophwitzko · commit 1e7c72cb863e · 2023-02-04T15:25:56.000+01:00
diff --git a/pkg/plugin/discovery/resolver/github/github.go b/pkg/plugin/discovery/resolver/github/github.go
@@ -18,6 +18,8 @@ import (
 	"golang.org/x/oauth2"
 )
 
+var _ resolver.Resolver = &Resolver{}
+
 type Resolver struct {
 	ghClient *github.Client
 }
@@ -105,6 +107,10 @@ func (g *Resolver) getAllValidGitHubReleases(repoOwner, repoName string) (ghRele
 				continue
 			}
 
+			if len(release.Assets) == 0 {
+				continue
+			}
+
 			if semverTag, err := semver.NewVersion(release.GetTagName()); err == nil {
 				ret = append(ret, &ghRelease{version: semverTag, release: release})
 			}
diff --git a/pkg/plugin/discovery/resolver/github/known_plugins.go b/pkg/plugin/discovery/resolver/github/known_plugins.go
@@ -1,17 +1,18 @@
 package github
 
 var knownPlugins = map[string]string{
-	"provider-github":             "go-semantic-release/provider-github",
-	"provider-gitlab":             "go-semantic-release/provider-gitlab",
-	"changelog-generator-default": "go-semantic-release/changelog-generator-default",
-	"commit-analyzer-default":     "go-semantic-release/commit-analyzer-cz",
-	"condition-default":           "go-semantic-release/condition-default",
-	"condition-github":            "go-semantic-release/condition-github",
-	"condition-gitlab":            "go-semantic-release/condition-gitlab",
-	"files-updater-npm":           "go-semantic-release/files-updater-npm",
-	"provider-git":                "go-semantic-release/provider-git",
-	"condition-bitbucket":         "go-semantic-release/condition-bitbucket",
-	"files-updater-helm":          "go-semantic-release/files-updater-helm",
-	"hooks-goreleaser":            "go-semantic-release/hooks-goreleaser",
-	"hooks-npm-binary-releaser":   "go-semantic-release/hooks-npm-binary-releaser",
+	"provider-github":              "go-semantic-release/provider-github",
+	"provider-gitlab":              "go-semantic-release/provider-gitlab",
+	"changelog-generator-default":  "go-semantic-release/changelog-generator-default",
+	"commit-analyzer-default":      "go-semantic-release/commit-analyzer-cz",
+	"condition-default":            "go-semantic-release/condition-default",
+	"condition-github":             "go-semantic-release/condition-github",
+	"condition-gitlab":             "go-semantic-release/condition-gitlab",
+	"files-updater-npm":            "go-semantic-release/files-updater-npm",
+	"provider-git":                 "go-semantic-release/provider-git",
+	"condition-bitbucket":          "go-semantic-release/condition-bitbucket",
+	"files-updater-helm":           "go-semantic-release/files-updater-helm",
+	"hooks-goreleaser":             "go-semantic-release/hooks-goreleaser",
+	"hooks-npm-binary-releaser":    "go-semantic-release/hooks-npm-binary-releaser",
+	"hooks-plugin-registry-update": "go-semantic-release/hooks-plugin-registry-update",
 }
diff --git a/pkg/plugin/discovery/resolver/registry/registry.go b/pkg/plugin/discovery/resolver/registry/registry.go
@@ -13,6 +13,11 @@ import (
 	"github.com/go-semantic-release/semantic-release/v2/pkg/plugin/discovery/resolver"
 )
 
+var (
+	_ resolver.Resolver      = &Resolver{}
+	_ resolver.BatchResolver = &Resolver{}
+)
+
 type Resolver struct {
 	client *client.Client
 }
diff --git a/pkg/plugin/discovery/resolver/registryV1/registry.go b/pkg/plugin/discovery/resolver/registryV1/registry.go
@@ -14,6 +14,8 @@ import (
 
 const DefaultEndpoint = "https://plugins.go-semantic-release.xyz/api/v1"
 
+var _ resolver.Resolver = &Resolver{}
+
 type Resolver struct {
 	endpoint string
 }

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,8 @@ import (`
`18`	`18`	`"golang.org/x/oauth2"`
`19`	`19`	`)`
`20`	`20`
	`21`	`+var _ resolver.Resolver = &Resolver{}`
	`22`	`+`
`21`	`23`	`type Resolver struct {`
`22`	`24`	`ghClient *github.Client`
`23`	`25`	`}`
`@@ -105,6 +107,10 @@ func (g *Resolver) getAllValidGitHubReleases(repoOwner, repoName string) (ghRele`
`105`	`107`	`continue`
`106`	`108`	`}`
`107`	`109`
	`110`	`+ if len(release.Assets) == 0 {`
	`111`	`+ continue`
	`112`	`+ }`
	`113`	`+`
`108`	`114`	`if semverTag, err := semver.NewVersion(release.GetTagName()); err == nil {`
`109`	`115`	`ret = append(ret, &ghRelease{version: semverTag, release: release})`
`110`	`116`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,11 @@ import (`
`13`	`13`	`"github.com/go-semantic-release/semantic-release/v2/pkg/plugin/discovery/resolver"`
`14`	`14`	`)`
`15`	`15`
	`16`	`+var (`
	`17`	`+ _ resolver.Resolver = &Resolver{}`
	`18`	`+ _ resolver.BatchResolver = &Resolver{}`
	`19`	`+)`
	`20`	`+`
`16`	`21`	`type Resolver struct {`
`17`	`22`	`client *client.Client`
`18`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ import (`
`14`	`14`
`15`	`15`	`const DefaultEndpoint = "https://plugins.go-semantic-release.xyz/api/v1"`
`16`	`16`
	`17`	`+var _ resolver.Resolver = &Resolver{}`
	`18`	`+`
`17`	`19`	`type Resolver struct {`
`18`	`20`	`endpoint string`
`19`	`21`	`}`