fix: only batch prefetch more than one plugin

christophwitzko · christophwitzko · commit 2b95d7bb34c0 · 2023-02-10T12:30:11.000+01:00
diff --git a/pkg/plugin/discovery/discovery.go b/pkg/plugin/discovery/discovery.go
@@ -124,10 +124,15 @@ func (d *Discovery) FindPluginsWithBatchResolver(resolverName string, pInfos []*
 		pInfo.BinPath = binPath
 	}
 
+	// no plugins need to be downloaded
 	if len(missingPlugins) == 0 {
 		return nil
 	}
 
+	if len(missingPlugins) == 1 {
+		return fmt.Errorf("no batch prefetching possible for a single plugin")
+	}
+
 	batchResolver := d.resolvers[resolverName].(resolver.BatchResolver)
 	batchDownloadInfo, err := batchResolver.BatchResolvePlugins(missingPlugins)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -124,10 +124,15 @@ func (d Discovery) FindPluginsWithBatchResolver(resolverName string, pInfos []`
`124`	`124`	`pInfo.BinPath = binPath`
`125`	`125`	`}`
`126`	`126`
	`127`	`+ // no plugins need to be downloaded`
`127`	`128`	`if len(missingPlugins) == 0 {`
`128`	`129`	`return nil`
`129`	`130`	`}`
`130`	`131`
	`132`	`+ if len(missingPlugins) == 1 {`
	`133`	`+ return fmt.Errorf("no batch prefetching possible for a single plugin")`
	`134`	`+ }`
	`135`	`+`
`131`	`136`	`batchResolver := d.resolvers[resolverName].(resolver.BatchResolver)`
`132`	`137`	`batchDownloadInfo, err := batchResolver.BatchResolvePlugins(missingPlugins)`
`133`	`138`	`if err != nil {`