fix: NPM_CONFIG_USERCONFIG env check

christophwitzko · christophwitzko · commit 2c38be176454 · 2020-07-05T16:39:27.000+02:00
diff --git a/pkg/update/package_json.go b/pkg/update/package_json.go
@@ -47,9 +47,14 @@ func packageJson(newVersion string, file *os.File) error {
 		}
 	}
 
+	if os.Getenv("NPM_CONFIG_USERCONFIG") != "" {
+		return nil
+	}
+
 	npmrcPath := path.Join(path.Dir(file.Name()), ".npmrc")
-	if _, err = os.Stat(npmrcPath); os.IsNotExist(err) && os.Getenv("NPM_CONFIG_USERCONFIG") == "" {
+	if _, err = os.Stat(npmrcPath); os.IsNotExist(err) {
 		return ioutil.WriteFile(npmrcPath, []byte(npmrc), 0644)
 	}
+
 	return err
 }

Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,14 @@ func packageJson(newVersion string, file *os.File) error {`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`
	`50`	`+ if os.Getenv("NPM_CONFIG_USERCONFIG") != "" {`
	`51`	`+ return nil`
	`52`	`+ }`
	`53`	`+`
`50`	`54`	`npmrcPath := path.Join(path.Dir(file.Name()), ".npmrc")`
`51`		`- if _, err = os.Stat(npmrcPath); os.IsNotExist(err) && os.Getenv("NPM_CONFIG_USERCONFIG") == "" {`
	`55`	`+ if _, err = os.Stat(npmrcPath); os.IsNotExist(err) {`
`52`	`56`	`return ioutil.WriteFile(npmrcPath, []byte(npmrc), 0644)`
`53`	`57`	`}`
	`58`	`+`
`54`	`59`	`return err`
`55`	`60`	`}`