fix(gitlab): repo visibility

Author: christophwitzko

pkg/semrel/github.go

@@ -24,9 +24,9 @@ func NewGithubRepository(ctx context.Context, gheHost, slug, token string) (*Git
 		return nil, errors.New("invalid slug")
 	}
 	repo := new(GithubRepository)
-	splited := strings.Split(slug, "/")
-	repo.owner = splited[0]
-	repo.repo = splited[1]
+	split := strings.Split(slug, "/")
+	repo.owner = split[0]
+	repo.repo = split[1]
 	repo.Ctx = ctx
 	oauthClient := oauth2.NewClient(ctx, oauth2.StaticTokenSource(&oauth2.Token{AccessToken: token}))
 	if gheHost != "" {

pkg/semrel/gitlab.go

@@ -20,15 +20,20 @@ type GitlabRepository struct {
 }
 
 func NewGitlabRepository(ctx context.Context, gitlabBaseUrl, slug, token, branch string, projectID string) (*GitlabRepository, error) {
-	repo := new(GitlabRepository)
-	repo.Ctx = ctx
-	repo.branch = branch
-
 	if projectID == "" {
 		return nil, fmt.Errorf("project id is required")
 	}
 
+	repo := new(GitlabRepository)
 	repo.projectID = projectID
+	repo.Ctx = ctx
+	repo.branch = branch
+
+	if strings.Contains(slug, "/") {
+		split := strings.Split(slug, "/")
+		repo.owner = split[0]
+		repo.repo = split[1]
+	}
 
 	var (
 		client *gitlab.Client
@@ -57,7 +62,7 @@ func (repo *GitlabRepository) GetInfo() (string, bool, error) {
 		return "", false, err
 	}
 
-	return project.DefaultBranch, !project.Public, nil
+	return project.DefaultBranch, project.Visibility == gitlab.PrivateVisibility, nil
 }
 
 func (repo *GitlabRepository) GetCommits(sha string) ([]*Commit, error) {

pkg/semrel/gitlab_test.go

@@ -20,7 +20,7 @@ func TestNewGitlabRepository(t *testing.T) {
 		t.Fatal("invalid initialization")
 	}
 	repo, err = NewGitlabRepository(context.TODO(), "", "owner/test-repo", "token", "", "1")
-	if repo == nil || err != nil {
+	if repo == nil || err != nil || repo.Owner() != "owner" || repo.Repo() != "test-repo" {
 		t.Fatal("invalid initialization")
 	}
 	repo, err = NewGitlabRepository(context.TODO(), "https://mygitlab.com", "owner/test-repo", "token", "", "1")
@@ -40,10 +40,9 @@ func createGitlabTag(name, sha string) *gitlab.Tag {
 }
 
 var (
-	GITLAB_REPO_PRIVATE  = true
 	GITLAB_PROJECT_ID    = 12324322
 	GITLAB_DEFAULTBRANCH = "master"
-	GITLAB_PROJECT       = gitlab.Project{DefaultBranch: GITLAB_DEFAULTBRANCH, Public: !GITLAB_REPO_PRIVATE, ID: GITLAB_PROJECT_ID}
+	GITLAB_PROJECT       = gitlab.Project{DefaultBranch: GITLAB_DEFAULTBRANCH, Visibility: gitlab.PrivateVisibility, ID: GITLAB_PROJECT_ID}
 	GITLAB_COMMITS       = []*gitlab.Commit{
 		createGitlabCommit("abcd", "feat(app): new feature"),
 		createGitlabCommit("dcba", "Fix: bug"),