Skip to content

Commit 5ef7c10

Browse files
refactor: simplify code
1 parent 5f546ba commit 5ef7c10

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

semrel.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ var typeToText = map[string]string{
198198
func getSortedKeys(m *map[string]string) []string {
199199
keys := make([]string, len(*m))
200200
i := 0
201-
for k, _ := range *m {
201+
for k := range *m {
202202
keys[i] = k
203203
i++
204204
}

semrel_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,9 @@ func TestCreateRelease(t *testing.T) {
152152

153153
func TestCaluclateChange(t *testing.T) {
154154
commits := []*Commit{
155-
&Commit{SHA: "a", Change: Change{true, false, false}},
156-
&Commit{SHA: "b", Change: Change{false, true, false}},
157-
&Commit{SHA: "c", Change: Change{false, false, true}},
155+
{SHA: "a", Change: Change{true, false, false}},
156+
{SHA: "b", Change: Change{false, true, false}},
157+
{SHA: "c", Change: Change{false, false, true}},
158158
}
159159
change := CaluclateChange(commits, &Release{})
160160
if !change.Major || !change.Minor || !change.Patch {
@@ -198,12 +198,12 @@ func TestApplyChange(t *testing.T) {
198198

199199
func TestGetChangelog(t *testing.T) {
200200
commits := []*Commit{
201-
&Commit{},
202-
&Commit{SHA: "123456789", Type: "feat", Scope: "app", Message: "commit message"},
203-
&Commit{SHA: "abcd", Type: "fix", Scope: "", Message: "commit message"},
204-
&Commit{SHA: "12345678", Type: "yolo", Scope: "swag", Message: "commit message"},
205-
&Commit{SHA: "12345678", Type: "chore", Scope: "", Message: "commit message", Raw: []string{"", "BREAKING CHANGE: test"}, Change: Change{Major: true}},
206-
&Commit{SHA: "stop", Type: "chore", Scope: "", Message: "not included"},
201+
{},
202+
{SHA: "123456789", Type: "feat", Scope: "app", Message: "commit message"},
203+
{SHA: "abcd", Type: "fix", Scope: "", Message: "commit message"},
204+
{SHA: "12345678", Type: "yolo", Scope: "swag", Message: "commit message"},
205+
{SHA: "12345678", Type: "chore", Scope: "", Message: "commit message", Raw: []string{"", "BREAKING CHANGE: test"}, Change: Change{Major: true}},
206+
{SHA: "stop", Type: "chore", Scope: "", Message: "not included"},
207207
}
208208
latestRelease := &Release{SHA: "stop"}
209209
newVersion, _ := semver.NewVersion("2.0.0")

0 commit comments

Comments
 (0)