Skip to content

Commit 61ea318

Browse files
refactor(GetLatestRelease): version parsing
1 parent 9e4dab6 commit 61ea318

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

cmd/semantic-release/main.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@ func main() {
6464
logger.Println("getting latest release...")
6565
release, rerr := repo.GetLatestRelease()
6666
exitIfError(rerr)
67-
if release.Version == nil {
68-
exitIfError(errors.New("found invalid version"))
69-
}
7067
logger.Println("found: " + release.Version.String())
7168

7269
logger.Println("getting commits...")

semrel.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,11 @@ func (repo *Repository) GetLatestRelease() (*Release, error) {
106106
if len(tags) == 0 {
107107
return &Release{"", &semver.Version{}}, nil
108108
}
109-
v, _ := semver.NewVersion(tags[0].GetName())
110-
return &Release{tags[0].Commit.GetSHA(), v}, nil
109+
version, verr := semver.NewVersion(tags[0].GetName())
110+
if verr != nil {
111+
return nil, verr
112+
}
113+
return &Release{tags[0].Commit.GetSHA(), version}, nil
111114
}
112115

113116
func (repo *Repository) CreateRelease(commits []*Commit, latestRelease *Release, newVersion *semver.Version) error {

0 commit comments

Comments
 (0)