Skip to content

Commit 65ae175

Browse files
cliedemanchristophwitzko
authored andcommitted
feat: Add from SHA to GetCommits
1 parent 827fb91 commit 65ae175

File tree

6 files changed

+77
-63
lines changed

6 files changed

+77
-63
lines changed

cmd/semantic-release/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ func cliHandler(cmd *cobra.Command, args []string) {
167167
}
168168

169169
logger.Println("getting commits...")
170-
rawCommits, err := prov.GetCommits(currentSha)
170+
rawCommits, err := prov.GetCommits(release.SHA, currentSha)
171171
exitIfError(err)
172172

173173
commitAnalyzer, err := pluginManager.GetCommitAnalyzer()

pkg/provider/provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ type Provider interface {
99
Name() string
1010
Version() string
1111
GetInfo() (*RepositoryInfo, error)
12-
GetCommits(sha string) ([]*semrel.RawCommit, error)
12+
GetCommits(fromSha, toSha string) ([]*semrel.RawCommit, error)
1313
GetReleases(re string) ([]*semrel.Release, error)
1414
CreateRelease(*CreateReleaseConfig) error
1515
}

pkg/provider/provider.pb.go

Lines changed: 66 additions & 56 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/provider/provider.proto

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ message GetInfo {
5151

5252
message GetCommits {
5353
message Request {
54-
string SHA = 1;
54+
string FromSHA = 1;
55+
string ToSHA = 2;
5556
}
5657
message Response {
5758
repeated RawCommit raw_commits = 1;

pkg/provider/wrapper.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func (s *Server) GetInfo(ctx context.Context, request *GetInfo_Request) (*GetInf
4040
}
4141

4242
func (s *Server) GetCommits(ctx context.Context, request *GetCommits_Request) (*GetCommits_Response, error) {
43-
commits, err := s.Impl.GetCommits(request.SHA)
43+
commits, err := s.Impl.GetCommits(request.FromSHA, request.ToSHA)
4444
if err != nil {
4545
return &GetCommits_Response{Error: err.Error()}, nil
4646
}
@@ -92,9 +92,10 @@ func (c *Client) GetInfo() (*RepositoryInfo, error) {
9292
return res.Info, nil
9393
}
9494

95-
func (c *Client) GetCommits(sha string) ([]*semrel.RawCommit, error) {
95+
func (c *Client) GetCommits(fromSha, toSha string) ([]*semrel.RawCommit, error) {
9696
res, err := c.Impl.GetCommits(context.Background(), &GetCommits_Request{
97-
SHA: sha,
97+
FromSHA: fromSha,
98+
ToSHA: toSha,
9899
})
99100
if err != nil {
100101
return nil, err

scripts/generate.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
set -euo pipefail
44

5-
shopt -s globstar
5+
if [[ "$OSTYPE" != "darwin"* ]]; then
6+
shopt -s globstar
7+
fi
68

79
for f in $(ls ./pkg/**/*.proto) ; do
810
echo "generating $f"

0 commit comments

Comments
 (0)