fix: cleanup orphan processes on linux

Author: christophwitzko

cmd/semantic-release/main.go

@@ -74,6 +74,7 @@ func cliHandler(cmd *cobra.Command, args []string) {
 	pluginManager, err := manager.New(conf)
 	exitIfError(err)
 	exitHandler = func() {
+		logger.Println("stopping plugins...")
 		pluginManager.Stop()
 	}
 

pkg/plugin/discovery/discovery.go

@@ -167,7 +167,7 @@ func (d *Discovery) fetchPlugin(name, pth string, cons *semver.Constraints) (str
 
 	releaseAsset := pluginInfo.Versions[foundVersion].getMatchingAsset()
 	if releaseAsset == nil {
-		return "", errors.New("release not found")
+		return "", fmt.Errorf("a matching plugin was not found for %s/%s", runtime.GOOS, runtime.GOARCH)
 	}
 
 	targetPath := path.Join(pth, foundVersion, releaseAsset.FileName)
@@ -304,9 +304,12 @@ func (d *Discovery) FindPlugin(t, name string) (*plugin.PluginOpts, error) {
 		}
 	}
 
+	cmd := exec.Command(binPath)
+	cmd.SysProcAttr = GetSysProcAttr()
+
 	return &plugin.PluginOpts{
 		Type:       t,
 		PluginName: pName,
-		Cmd:        exec.Command(binPath),
+		Cmd:        cmd,
 	}, nil
 }

pkg/plugin/discovery/sysprocattr.go

@@ -0,0 +1,9 @@
+// +build !linux
+
+package discovery
+
+import "syscall"
+
+func GetSysProcAttr() *syscall.SysProcAttr {
+	return nil
+}

pkg/plugin/discovery/sysprocattr_linux.go

@@ -0,0 +1,11 @@
+// +build linux
+
+package discovery
+
+import "syscall"
+
+func GetSysProcAttr() *syscall.SysProcAttr {
+	return &syscall.SysProcAttr{
+		Pdeathsig: syscall.SIGKILL,
+	}
+}