refactor: golangci-lint

Author: christophwitzko

pkg/config/config.go

@@ -62,7 +62,10 @@ func NewConfig(c *cli.Context) *Config {
 	defer f.Close()
 
 	src := &BetaRelease{}
-	json.NewDecoder(f).Decode(src)
+	if err := json.NewDecoder(f).Decode(src); err != nil {
+		return conf
+	}
+
 	conf.BetaRelease = *src
 
 	return conf

pkg/semrel/github.go

@@ -68,7 +68,7 @@ func (repo *GitHubRepository) GetCommits(sha string) ([]*Commit, error) {
 
 func (repo *GitHubRepository) GetLatestRelease(vrange string, re *regexp.Regexp) (*Release, error) {
 	allReleases := make(Releases, 0)
-	opts := &github.ReferenceListOptions{"tags", github.ListOptions{PerPage: 100}}
+	opts := &github.ReferenceListOptions{Type: "tags", ListOptions: github.ListOptions{PerPage: 100}}
 	for {
 		refs, resp, err := repo.Client.Git.ListRefs(repo.Ctx, repo.owner, repo.repo, opts)
 		if resp != nil && resp.StatusCode == 404 {

pkg/semrel/github_test.go

@@ -58,6 +58,7 @@ var (
 	}
 )
 
+//nolint:errcheck
 func githubHandler(w http.ResponseWriter, r *http.Request) {
 	if r.Header.Get("Authorization") != "Bearer token" {
 		http.Error(w, "unauthorized", http.StatusUnauthorized)

pkg/semrel/gitlab_test.go

@@ -60,6 +60,7 @@ var (
 	}
 )
 
+//nolint:errcheck
 func GitlabHandler(w http.ResponseWriter, r *http.Request) {
 	// Rate Limit headers
 	if r.Method == "GET" && r.URL.Path == "/api/v4/" {

pkg/semrel/semrel.go

@@ -12,7 +12,7 @@ import (
 	"github.com/go-semantic-release/semantic-release/pkg/config"
 )
 
-var commitPattern = regexp.MustCompile("^(\\w*)(?:\\((.*)\\))?\\: (.*)$")
+var commitPattern = regexp.MustCompile(`^(\w*)(?:\((.*)\))?\: (.*)$`)
 var breakingPattern = regexp.MustCompile("BREAKING CHANGES?")
 
 type Change struct {
@@ -133,13 +133,10 @@ func ApplyChange(version *semver.Version, change Change, allowInitialDevelopment
 		switch {
 		case change.Major:
 			newVersion = version.IncMajor()
-			break
 		case change.Minor:
 			newVersion = version.IncMinor()
-			break
 		case change.Patch:
 			newVersion = version.IncPatch()
-			break
 		}
 		return &newVersion
 	}

pkg/update/package_json.go

@@ -19,8 +19,12 @@ func updateJsonFile(newVersion string, file *os.File) error {
 		return err
 	}
 	data["version"] = json.RawMessage("\"" + newVersion + "\"")
-	file.Seek(0, 0)
-	file.Truncate(0)
+	if _, err := file.Seek(0, 0); err != nil {
+		return err
+	}
+	if err := file.Truncate(0); err != nil {
+		return err
+	}
 	enc := json.NewEncoder(file)
 	enc.SetIndent("", "  ")
 	if err := enc.Encode(data); err != nil {

pkg/update/package_json_test.go

@@ -18,16 +18,22 @@ func TestPackageJson(t *testing.T) {
 	nVerJson := []byte("\"" + nVer + "\"")
 	npmrcPath := "../../test/.npmrc"
 	os.Remove(npmrcPath)
-	packageJson(nVer, f)
+	if err := packageJson(nVer, f); err != nil {
+		t.Fatal(err)
+	}
 	npmfile, err := ioutil.ReadFile(npmrcPath)
-	if err != nil || bytes.Compare(npmfile, []byte(npmrc)) != 0 {
+	if err != nil || !bytes.Equal(npmfile, []byte(npmrc)) {
 		t.Fatal("invalid .npmrc")
 	}
 
-	f.Seek(0, 0)
+	if _, err := f.Seek(0, 0); err != nil {
+		t.Fatal(err)
+	}
 	var data map[string]json.RawMessage
-	json.NewDecoder(f).Decode(&data)
-	if bytes.Compare(data["version"], nVerJson) != 0 {
+	if err := json.NewDecoder(f).Decode(&data); err != nil {
+		t.Fatal(err)
+	}
+	if !bytes.Equal(data["version"], nVerJson) {
 		t.Fatal("invalid version")
 	}
 
@@ -36,8 +42,10 @@ func TestPackageJson(t *testing.T) {
 		t.Fatal("fixture package-lock.json missing")
 	}
 	var plData map[string]json.RawMessage
-	json.NewDecoder(plF).Decode(&plData)
-	if bytes.Compare(plData["version"], nVerJson) != 0 {
+	if err := json.NewDecoder(plF).Decode(&plData); err != nil {
+		t.Fatal(err)
+	}
+	if !bytes.Equal(plData["version"], nVerJson) {
 		t.Fatal("invalid version")
 	}
 }
@@ -50,16 +58,24 @@ func TestNpmrc(t *testing.T) {
 	defer f.Close()
 	nVer := "1.2.3"
 	npmrcPath := "../../test/.npmrc"
-	ioutil.WriteFile(npmrcPath, []byte("TEST"), 0644)
-	packageJson(nVer, f)
+	if err := ioutil.WriteFile(npmrcPath, []byte("TEST"), 0644); err != nil {
+		t.Fatal(err)
+	}
+	if err := packageJson(nVer, f); err != nil {
+		t.Fatal(err)
+	}
 	npmfile, err := ioutil.ReadFile(npmrcPath)
-	if err != nil || bytes.Compare(npmfile, []byte("TEST")) != 0 {
+	if err != nil || !bytes.Equal(npmfile, []byte("TEST")) {
 		t.Fatal("invalid .npmrc")
 	}
-	f.Seek(0, 0)
+	if _, err := f.Seek(0, 0); err != nil {
+		t.Fatal(err)
+	}
 	var data map[string]json.RawMessage
-	json.NewDecoder(f).Decode(&data)
-	if bytes.Compare(data["version"], []byte("\""+nVer+"\"")) != 0 {
+	if err := json.NewDecoder(f).Decode(&data); err != nil {
+		t.Fatal(err)
+	}
+	if !bytes.Equal(data["version"], []byte("\""+nVer+"\"")) {
 		t.Fatal("invalid version")
 	}
 }