Skip to content

Commit f058d54

Browse files
cliedemanchristophwitzko
authored andcommitted
feat: Change initial release to work as expected
1 parent 8afe7e8 commit f058d54

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

pkg/semrel/semrel.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ func CalculateChange(commits []*Commit, latestRelease *Release) Change {
114114
}
115115

116116
func ApplyChange(version *semver.Version, change Change) *semver.Version {
117-
if version.Major() == 0 {
118-
change.Major = true
119-
}
120117
if !change.Major && !change.Minor && !change.Patch {
121118
return nil
122119
}

pkg/semrel/semrel_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ func TestApplyChange(t *testing.T) {
4141
expectedVersion string
4242
}{
4343
// No Previous Releases
44-
{"0.0.0", NoChange, "1.0.0"},
45-
{"0.0.0", PatchChange, "1.0.0"},
46-
{"0.0.0", MinorChange, "1.0.0"},
44+
{"0.0.0", NoChange, "0.0.0"},
45+
{"0.0.0", PatchChange, "0.0.1"},
46+
{"0.0.0", MinorChange, "0.1.0"},
4747
{"0.0.0", MajorChange, "1.0.0"},
4848

4949
{"1.0.0", NoChange, ""},
@@ -68,7 +68,7 @@ func TestApplyChange(t *testing.T) {
6868
actual := ApplyChange(current, tc.change)
6969

7070
// Handle no new version case
71-
if actual != nil && tc.expectedVersion == "" {
71+
if actual != nil && tc.expectedVersion != "" {
7272
if actual.String() != tc.expectedVersion {
7373
t.Errorf("expected: %s, got: %s", tc.expectedVersion, actual)
7474
}

0 commit comments

Comments
 (0)