Add Doctrine entities support, tests, commands, documentation, XSD schema #16

Author: TheCelavi

.gitignore

@@ -1 +1,4 @@
 /vendor/
+/build/
+/Tests/Fixtures/project/var/cache/*
+/Tests/Fixtures/project/var/logs/*

.scrutinizer.yml

@@ -0,0 +1,19 @@
+filter:
+    excluded_paths: [vendor/*, Tests/*, bin/*, Resources/]
+checks:
+    php: true
+tools:
+    external_code_coverage:
+        timeout: 600
+    php_sim: true
+    php_mess_detector: true
+    php_cs_fixer: true
+    php_analyzer: true
+    php_code_sniffer: true
+    sensiolabs_security_checker: true
+    php_loc:
+        enabled: true
+        excluded_dirs:        [vendor]
+    php_pdepend:
+        enabled: true
+        excluded_dirs:        [vendor, Tests, bin]

.travis.yml

@@ -0,0 +1,19 @@
+language: php
+
+php:
+  - 5.6
+  - 7.0
+  - 7.1
+
+sudo: false
+
+cache:
+  directories:
+    - $HOME/.composer/cache/files
+
+before_install:
+  - composer self-update
+
+install: composer update --prefer-source
+
+script: vendor/bin/phpunit --coverage-clover=coverage.clover

CacheWarmer/AspectCacheWarmer.php

@@ -83,7 +83,6 @@ public function warmUp($cacheDir)
             throw new \ErrorException($errstr, $errno, 0, $errfile, $errline);
         });
 
-        $errors = array();
         foreach ($iterator as $file) {
             $realPath = $file->getRealPath();
             try {
@@ -94,7 +93,7 @@ public function warmUp($cacheDir)
                     "/resource=" . $realPath
                 );
             } catch (\Exception $e) {
-                $errors[$realPath] = $e;
+                /* noop */
             }
         }
 

Command/CacheWarmupCommand.php

@@ -0,0 +1,49 @@
+<?php
+/**
+ * Go! AOP framework
+ *
+ * @copyright Copyright 2015, Lisachenko Alexander <lisachenko.it@gmail.com>
+ *
+ * This source file is subject to the license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Go\Symfony\GoAopBundle\Command;
+
+use Go\Core\AspectKernel;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Go\Console\Command\CacheWarmupCommand as BaseCommand;
+
+/**
+ * Console command for warming the cache
+ *
+ * @codeCoverageIgnore
+ */
+class CacheWarmupCommand extends BaseCommand
+{
+    public function __construct(AspectKernel $aspectKernel)
+    {
+        parent::__construct(null);
+        $this->aspectKernel = $aspectKernel;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function configure()
+    {
+        parent::configure();
+        $arguments = $this->getDefinition()->getArguments();
+        unset($arguments['loader']);
+        $this->getDefinition()->setArguments($arguments);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function loadAspectKernel(InputInterface $input, OutputInterface $output)
+    {
+        /* noop */
+    }
+}

Command/DebugAdvisorCommand.php

@@ -0,0 +1,49 @@
+<?php
+/**
+ * Go! AOP framework
+ *
+ * @copyright Copyright 2015, Lisachenko Alexander <lisachenko.it@gmail.com>
+ *
+ * This source file is subject to the license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Go\Symfony\GoAopBundle\Command;
+
+use Go\Core\AspectKernel;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Go\Console\Command\DebugAdvisorCommand as BaseCommand;
+
+/**
+ * Console command to debug an advisors
+ *
+ * @codeCoverageIgnore
+ */
+class DebugAdvisorCommand extends BaseCommand
+{
+    public function __construct(AspectKernel $aspectKernel)
+    {
+        parent::__construct(null);
+        $this->aspectKernel = $aspectKernel;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function configure()
+    {
+        parent::configure();
+        $arguments = $this->getDefinition()->getArguments();
+        unset($arguments['loader']);
+        $this->getDefinition()->setArguments($arguments);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function loadAspectKernel(InputInterface $input, OutputInterface $output)
+    {
+        /* noop */
+    }
+}

Command/DebugAspectCommand.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * Go! AOP framework
+ *
+ * @copyright Copyright 2015, Lisachenko Alexander <lisachenko.it@gmail.com>
+ *
+ * This source file is subject to the license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Go\Symfony\GoAopBundle\Command;
+
+use Go\Core\AspectKernel;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Go\Console\Command\DebugAspectCommand as BaseCommand;
+
+/**
+ * Class DebugAspectCommand
+ *
+ * Console command for querying an information about aspects
+ *
+ * @codeCoverageIgnore
+ */
+class DebugAspectCommand extends BaseCommand
+{
+    public function __construct(AspectKernel $aspectKernel)
+    {
+        parent::__construct(null);
+        $this->aspectKernel = $aspectKernel;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function configure()
+    {
+        parent::configure();
+        $arguments = $this->getDefinition()->getArguments();
+        unset($arguments['loader']);
+        $this->getDefinition()->setArguments($arguments);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function loadAspectKernel(InputInterface $input, OutputInterface $output)
+    {
+        /* noop */
+    }
+}

DependencyInjection/Compiler/AspectCollectorPass.php

@@ -19,16 +19,15 @@
  */
 class AspectCollectorPass implements CompilerPassInterface
 {
-
     /**
-     * You can modify the container here before it is dumped to PHP code.
-     *
-     * @param ContainerBuilder $container
-     *
-     * @api
+     * {@inheritdoc}
      */
     public function process(ContainerBuilder $container)
     {
+        if (!$container->hasDefinition('goaop.aspect.container')) {
+            return;
+        }
+
         $aspectIds       = $container->findTaggedServiceIds('goaop.aspect');
         $aspectContainer = $container->getDefinition('goaop.aspect.container');
         foreach ($aspectIds as $aspectId => $aspectTags) {

DependencyInjection/Configuration.php

@@ -34,8 +34,12 @@ public function getConfigTreeBuilder()
         $rootNode
             ->children()
                 ->booleanNode('cache_warmer')->defaultTrue()->end()
+                ->booleanNode('doctrine_support')->defaultFalse()->end()
                 ->arrayNode('options')
                     ->addDefaultsIfNotSet()
+                    ->fixXmlConfig('feature', 'features')
+                    ->fixXmlConfig('include_path', 'include_paths')
+                    ->fixXmlConfig('exclude_path', 'exclude_paths')
                     ->children()
                         ->scalarNode('features')
                             ->beforeNormalization()
@@ -47,7 +51,7 @@ public function getConfigTreeBuilder()
                                         if (!isset($features[$featureName])) {
                                             throw new InvalidConfigurationException("Uknown feature: {$featureName}");
                                         }
-                                        $featureMask += isset($features[$featureName]) ? $features[$featureName] : 0;
+                                        $featureMask |= $features[$featureName];
                                     }
 
                                     return $featureMask;

DependencyInjection/GoAopExtension.php

@@ -18,6 +18,21 @@
 
 class GoAopExtension extends Extension
 {
+    /**
+     * {@inheritdoc}
+     */
+    public function getNamespace()
+    {
+        return 'http://go.aopphp.com/xsd-schema/go-aop-bundle';
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getXsdValidationBasePath()
+    {
+        return __DIR__ . '/../Resources/config/schema';
+    }
 
     /**
      * Loads a specific configuration.
@@ -42,12 +57,19 @@ public function load(array $config, ContainerBuilder $container)
         }
         $container->setParameter('goaop.options', $normalizedOptions);
 
-        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
+        $loader->load('commands.xml');
 
         if ($config['cache_warmer']) {
             $definition = $container->getDefinition('goaop.cache.warmer');
             $definition->addTag('kernel.cache_warmer');
         }
+
+        if ($config['doctrine_support']) {
+            $container
+                ->getDefinition('goaop.bridge.doctrine.metadata_load_interceptor')
+                ->addTag('doctrine.event_subscriber');
+        }
     }
 }