From beaad9443fb4961d1440ac0f93720056705e977a Mon Sep 17 00:00:00 2001 From: Dmitry Savintsev Date: Fri, 8 Nov 2024 21:18:06 +0100 Subject: [PATCH 1/3] update local devel instructions in README.md PR updates the local development instructions in README.md that are currently causing errors since `npm run` doesn't contain `prepare-dips`. Fix #1124. --- README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0a738c8bda..3abc8590a1 100644 --- a/README.md +++ b/README.md @@ -544,5 +544,7 @@ This scheme is basic and needs improvements. Pull requests and ideas are welcome 1. Install [act](https://github.com/nektos/act#installation) 2. Make a symlink for `act` to work properly: `ln -s . golangci-lint-action` -3. Prepare deps once: `npm run prepare-deps` -4. Run `npm run local` after any change to test it +3. Instally typescript (on a Mac, `brew install tsc`) +4. Prepare deps once: `npm install` +5. Build: `npm run build` +6. Run `npm run local` after any change to test it From 4e40cf8d2a81e23704c7064cde45fa6342dd96ec Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Fri, 8 Nov 2024 21:22:03 +0100 Subject: [PATCH 2/3] review --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3abc8590a1..5a1f2fc277 100644 --- a/README.md +++ b/README.md @@ -544,7 +544,7 @@ This scheme is basic and needs improvements. Pull requests and ideas are welcome 1. Install [act](https://github.com/nektos/act#installation) 2. Make a symlink for `act` to work properly: `ln -s . golangci-lint-action` -3. Instally typescript (on a Mac, `brew install tsc`) +3. Install Typescript 4. Prepare deps once: `npm install` 5. Build: `npm run build` 6. Run `npm run local` after any change to test it From 89abc069df826636512c0df9296e6e9631b6b4dc Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Fri, 8 Nov 2024 21:31:30 +0100 Subject: [PATCH 3/3] review --- README.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 5a1f2fc277..7e05e454ab 100644 --- a/README.md +++ b/README.md @@ -544,7 +544,6 @@ This scheme is basic and needs improvements. Pull requests and ideas are welcome 1. Install [act](https://github.com/nektos/act#installation) 2. Make a symlink for `act` to work properly: `ln -s . golangci-lint-action` -3. Install Typescript -4. Prepare deps once: `npm install` -5. Build: `npm run build` -6. Run `npm run local` after any change to test it +3. Install dependencies: `npm install` +4. Build: `npm run build` +5. Run `npm run local` after any change to test it