Merge pull request #1060 from gooddata/liry4

Add AuthenticationMode enum to Account

Reviewed-by: Jiri Mikulasek <jiri.mikulasek@gooddata.com>
             https://github.com/jimirocks

Author: gdgate

gooddata-java-model/src/main/java/com/gooddata/sdk/model/account/Account.java

@@ -6,8 +6,8 @@
 package com.gooddata.sdk.model.account;
 
 import com.fasterxml.jackson.annotation.*;
-import com.gooddata.sdk.model.util.UriHelper;
 import com.gooddata.sdk.common.util.GoodDataToStringBuilder;
+import com.gooddata.sdk.model.util.UriHelper;
 
 import java.util.List;
 
@@ -205,4 +205,18 @@ public String toString() {
      */
     public static class UpdateView {
     }
+
+    /**
+     * Enumeration type representing GoodData authentication mode.
+     */
+    public enum AuthenticationMode {
+        /**
+         * User can be authenticated using password
+         */
+        PASSWORD,
+        /**
+         * User can be authenticated via SSO
+         */
+        SSO
+    }
 }

gooddata-java-model/src/test/java/com/gooddata/sdk/model/account/AccountTest.java

@@ -7,6 +7,7 @@
 
 import org.testng.annotations.Test;
 
+import static com.gooddata.sdk.model.account.Account.AuthenticationMode.SSO;
 import static net.javacrumbs.jsonunit.JsonMatchers.jsonEquals;
 import static net.javacrumbs.jsonunit.core.util.ResourceUtils.resource;
 import static com.gooddata.sdk.common.util.ResourceUtils.readObjectFromResource;
@@ -37,14 +38,14 @@ public void testDeserialize() throws Exception {
         assertThat(account.getUri(), is("/gdc/account/profile/ID"));
         assertThat(account.getProjectsUri(), is("/gdc/account/profile/ID/projects"));
         assertThat(account.getIpWhitelist(), contains(IP));
-        assertThat(account.getAuthenticationModes(), contains("SSO"));
+        assertThat(account.getAuthenticationModes(), contains(SSO.toString()));
     }
 
     @Test
     public void testSerialization() {
         final Account account = new Account(FIRST_NAME, LAST_NAME, null);
         account.setIpWhitelist(Collections.singletonList("1.2.3.4/32"));
-        account.setAuthenticationModes(Collections.singletonList("SSO"));
+        account.setAuthenticationModes(Collections.singletonList(SSO.toString()));
         assertThat(account, jsonEquals(resource("account/account-input.json")));
     }
 

gooddata-java/src/test/java/com/gooddata/sdk/service/account/AccountServiceAT.java

@@ -11,12 +11,13 @@
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.Test;
 
-import java.util.Collections;
 import java.util.UUID;
 
+import static com.gooddata.sdk.model.account.Account.AuthenticationMode.PASSWORD;
+import static com.gooddata.sdk.model.account.Account.AuthenticationMode.SSO;
+import static java.util.Arrays.asList;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.Matchers.is;
-import static org.hamcrest.Matchers.notNullValue;
+import static org.hamcrest.Matchers.*;
 
 /**
  * Account acceptance tests.
@@ -39,13 +40,13 @@ public void login() throws Exception {
     @Test(groups = "isolated_domain")
     public void createAccount() {
         final Account newAccount = new Account(LOGIN, "w4yYxSQpAbaODA64", "FistName", "LastName");
-        newAccount.setAuthenticationModes(Collections.singletonList("SSO"));
+        newAccount.setAuthenticationModes(asList(SSO.toString(), PASSWORD.toString()));
         account = accountService.createAccount(newAccount, getProperty("domain"));
 
         assertThat(account, is(notNullValue()));
         assertThat(account.getId(), is(notNullValue()));
         assertThat(account.getLogin(), is(LOGIN));
-        assertThat(account.getAuthenticationModes(), is(Collections.singletonList("SSO")));
+        assertThat(account.getAuthenticationModes(), containsInAnyOrder(SSO.toString(), PASSWORD.toString()));
     }
 
     @Test(groups = "isolated_domain", dependsOnMethods = "createAccount")
@@ -69,7 +70,7 @@ public void getSeparatorSettings() {
     }
 
     @Test(groups = "isolated_domain", dependsOnMethods = "getSeparatorSettings")
-    public void updateAccount() throws Exception {
+    public void updateAccount() {
         final String newName = "Petra";
         account.setFirstName(newName);
 

gooddata-java/src/test/java/com/gooddata/sdk/service/account/AccountServiceIT.java

@@ -12,11 +12,11 @@
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
-import java.io.IOException;
 import java.util.Collections;
 import java.util.List;
 
 import static com.gooddata.sdk.common.util.ResourceUtils.*;
+import static com.gooddata.sdk.model.account.Account.AuthenticationMode.SSO;
 import static net.jadler.Jadler.onRequest;
 import static net.javacrumbs.jsonunit.JsonMatchers.jsonEquals;
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -40,13 +40,13 @@ public class AccountServiceIT extends AbstractGoodDataIT {
     private static Account createAccount;
 
     @BeforeClass
-    public void init() throws IOException {
+    public void init() {
         account = readObjectFromResource(ACCOUNT, Account.class);
         createAccount = readObjectFromResource(CREATE_ACCOUNT, Account.class);
     }
 
     @Test
-    public void shouldCreateAccount() throws Exception {
+    public void shouldCreateAccount() {
         onRequest()
                 .havingMethodEqualTo("POST")
                 .havingPathEqualTo(AccountService.ACCOUNTS_TEMPLATE.expand(DOMAIN).toString())
@@ -79,7 +79,7 @@ public void shouldFailToCreateAccount() {
     }
 
     @Test
-    public void shouldRemoveAccount() throws Exception {
+    public void shouldRemoveAccount() {
         onRequest()
                 .havingMethodEqualTo("DELETE")
                 .havingPathEqualTo(ACCOUNT_URI)
@@ -90,7 +90,7 @@ public void shouldRemoveAccount() throws Exception {
     }
 
     @Test(expectedExceptions = AccountNotFoundException.class)
-    public void shouldFailToFindAccountForRemoval() throws Exception {
+    public void shouldFailToFindAccountForRemoval() {
         onRequest()
                 .havingMethodEqualTo("DELETE")
                 .havingPathEqualTo(ACCOUNT_URI)
@@ -116,7 +116,7 @@ public void shouldGetCurrentAccount() {
     }
 
     @Test(expectedExceptions = GoodDataException.class)
-    public void shouldFailToGetCurrentAccount() throws Exception {
+    public void shouldFailToGetCurrentAccount() {
         onRequest()
                 .havingMethodEqualTo("GET")
                 .havingPathEqualTo(CURRENT_ACCOUNT_URI)
@@ -127,7 +127,7 @@ public void shouldFailToGetCurrentAccount() throws Exception {
     }
 
     @Test(expectedExceptions = AccountNotFoundException.class)
-    public void shouldFailToFindCurrentAccount() throws Exception {
+    public void shouldFailToFindCurrentAccount() {
         onRequest()
                 .havingMethodEqualTo("GET")
                 .havingPathEqualTo(CURRENT_ACCOUNT_URI)
@@ -210,7 +210,7 @@ public void shouldFailOnUpdateNonExistentAccount() {
     }
 
     @Test
-    public void shouldUpdateAccount() throws Exception {
+    public void shouldUpdateAccount() {
         onRequest()
                 .havingMethodEqualTo("PUT")
                 .havingPathEqualTo(ACCOUNT_URI)
@@ -224,7 +224,7 @@ public void shouldUpdateAccount() throws Exception {
         final String newEmail = "fake2@gooddata.com";
         final String newPass = "password2";
         final String newLastName = "Muhehe2";
-        final List<String> authenticationModes = Collections.singletonList("SSO");
+        final List<String> authenticationModes = Collections.singletonList(SSO.toString());
 
         toBeUpdated.setFirstName(newFirstName);
         toBeUpdated.setEmail(newEmail);