Skip to content

Commit 6676f7c

Browse files
author
gdgate
authored
Merge pull request #1057 from cipous/1056_authenticationModes
Add authenticationModes to Account.java Reviewed-by: Peter Plocháň https://github.com/peter-plochan
2 parents 2ab6159 + b0cc98a commit 6676f7c

File tree

7 files changed

+31
-8
lines changed

7 files changed

+31
-8
lines changed

gooddata-java-model/src/main/java/com/gooddata/sdk/model/account/Account.java

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ public class Account {
4747
@JsonView(UpdateView.class)
4848
private List<String> ipWhitelist;
4949

50+
@JsonView(UpdateView.class)
51+
private List<String> authenticationModes;
52+
5053
@JsonIgnore
5154
private final Links links;
5255

@@ -59,6 +62,7 @@ private Account(
5962
@JsonProperty("firstName") String firstName,
6063
@JsonProperty("lastName") String lastName,
6164
@JsonProperty("ipWhitelist") List<String> ipWhitelist,
65+
@JsonProperty("authenticationModes") List<String> authenticationModes,
6266
@JsonProperty("links") Links links
6367
) {
6468
this.login = login;
@@ -68,11 +72,12 @@ private Account(
6872
this.firstName = firstName;
6973
this.lastName = lastName;
7074
this.ipWhitelist = ipWhitelist;
75+
this.authenticationModes = authenticationModes;
7176
this.links = links;
7277
}
7378

7479
public Account(String firstName, String lastName, Links links) {
75-
this(null, null, null, null, firstName, lastName, null, links);
80+
this(null, null, null, null, firstName, lastName, null, null, links);
7681
}
7782

7883
/**
@@ -83,7 +88,7 @@ public Account(String firstName, String lastName, Links links) {
8388
* @param password password
8489
*/
8590
public Account(String email, String password, String firstName, String lastName) {
86-
this(email, email, password, password, firstName, lastName, null, null);
91+
this(email, email, password, password, firstName, lastName, null, null, null);
8792
}
8893

8994
public String getLogin() {
@@ -129,6 +134,10 @@ public List<String> getIpWhitelist() {
129134
return ipWhitelist;
130135
}
131136

137+
public List<String> getAuthenticationModes() {
138+
return authenticationModes;
139+
}
140+
132141
public void setEmail(final String email) {
133142
this.email = email;
134143
}
@@ -153,6 +162,10 @@ public void setIpWhitelist(final List<String> ipWhitelist) {
153162
this.ipWhitelist = ipWhitelist;
154163
}
155164

165+
public void setAuthenticationModes(final List<String> authenticationModes) {
166+
this.authenticationModes = authenticationModes;
167+
}
168+
156169
@JsonIgnoreProperties(ignoreUnknown = true)
157170
private static class Links {
158171
private final String self;

gooddata-java-model/src/test/java/com/gooddata/sdk/model/account/AccountTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import static org.hamcrest.Matchers.contains;
1717
import static org.hamcrest.text.MatchesPattern.matchesPattern;
1818

19-
import java.util.Arrays;
19+
import java.util.Collections;
2020

2121
public class AccountTest {
2222

@@ -37,12 +37,14 @@ public void testDeserialize() throws Exception {
3737
assertThat(account.getUri(), is("/gdc/account/profile/ID"));
3838
assertThat(account.getProjectsUri(), is("/gdc/account/profile/ID/projects"));
3939
assertThat(account.getIpWhitelist(), contains(IP));
40+
assertThat(account.getAuthenticationModes(), contains("SSO"));
4041
}
4142

4243
@Test
4344
public void testSerialization() {
4445
final Account account = new Account(FIRST_NAME, LAST_NAME, null);
45-
account.setIpWhitelist(Arrays.asList("1.2.3.4/32"));
46+
account.setIpWhitelist(Collections.singletonList("1.2.3.4/32"));
47+
account.setAuthenticationModes(Collections.singletonList("SSO"));
4648
assertThat(account, jsonEquals(resource("account/account-input.json")));
4749
}
4850

gooddata-java-model/src/test/resources/account/account-input.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"accountSetting" : {
33
"firstName" : "Blah",
44
"lastName" : "Muhehe",
5-
"ipWhitelist" : ["1.2.3.4/32"]
5+
"ipWhitelist" : ["1.2.3.4/32"],
6+
"authenticationModes" : ["SSO"]
67
}
78
}

gooddata-java-model/src/test/resources/account/account.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"ssoProvider" : null,
66
"timezone" : null,
77
"position" : null,
8-
"authenticationModes" : [],
8+
"authenticationModes" : ["SSO"],
99
"companyName" : "gdc",
1010
"login" : "fake@gooddata.com",
1111
"email" : "fake@gooddata.com",

gooddata-java/src/test/java/com/gooddata/sdk/service/account/AccountServiceAT.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import org.testng.annotations.AfterClass;
1212
import org.testng.annotations.Test;
1313

14+
import java.util.Collections;
1415
import java.util.UUID;
1516

1617
import static org.hamcrest.MatcherAssert.assertThat;
@@ -38,12 +39,13 @@ public void login() throws Exception {
3839
@Test(groups = "isolated_domain")
3940
public void createAccount() {
4041
final Account newAccount = new Account(LOGIN, "w4yYxSQpAbaODA64", "FistName", "LastName");
41-
42+
newAccount.setAuthenticationModes(Collections.singletonList("SSO"));
4243
account = accountService.createAccount(newAccount, getProperty("domain"));
4344

4445
assertThat(account, is(notNullValue()));
4546
assertThat(account.getId(), is(notNullValue()));
4647
assertThat(account.getLogin(), is(LOGIN));
48+
assertThat(account.getAuthenticationModes(), is(Collections.singletonList("SSO")));
4749
}
4850

4951
@Test(groups = "isolated_domain", dependsOnMethods = "createAccount")

gooddata-java/src/test/java/com/gooddata/sdk/service/account/AccountServiceIT.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
import org.testng.annotations.Test;
1414

1515
import java.io.IOException;
16+
import java.util.Collections;
17+
import java.util.List;
1618

1719
import static com.gooddata.sdk.common.util.ResourceUtils.*;
1820
import static net.jadler.Jadler.onRequest;
@@ -222,12 +224,14 @@ public void shouldUpdateAccount() throws Exception {
222224
final String newEmail = "fake2@gooddata.com";
223225
final String newPass = "password2";
224226
final String newLastName = "Muhehe2";
227+
final List<String> authenticationModes = Collections.singletonList("SSO");
225228

226229
toBeUpdated.setFirstName(newFirstName);
227230
toBeUpdated.setEmail(newEmail);
228231
toBeUpdated.setPassword(newPass);
229232
toBeUpdated.setVerifyPassword(newPass);
230233
toBeUpdated.setLastName(newLastName);
234+
toBeUpdated.setAuthenticationModes(authenticationModes);
231235

232236
gd.getAccountService().updateAccount(toBeUpdated);
233237
}

gooddata-java/src/test/resources/account/update-account.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"verifyPassword": "password2",
66
"firstName" : "newFirstName2",
77
"lastName" : "Muhehe2",
8-
"ipWhitelist" : ["1.2.3.4/32"]
8+
"ipWhitelist" : ["1.2.3.4/32"],
9+
"authenticationModes" : ["SSO"]
910
}
1011
}

0 commit comments

Comments
 (0)