Skip to content

Commit 5ad5041

Browse files
feat: added aria-labels to header, footer and some nav elements
risk: low JIRA: DP-3086
1 parent f1d2510 commit 5ad5041

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

docs/layouts/_default/baseof.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
</head>
77
<body class="td-{{ .Kind }}">
88
{{ partial "gtm-body.html" }}
9-
<header>
9+
<header aria-label="Main site header">
1010
{{ partial "navbar.html" . }}
1111
</header>
1212
<div class="container-fluid td-default td-outer">
13-
<main role="main" class="td-main">
13+
<main role="main" class="td-main" aria-label="Article content">
1414
{{ block "main" . }}{{ end }}
1515
</main>
1616
{{ partialCached "footer.html" . }}

docs/layouts/docs/baseof.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</head>
1111
<body class="td-{{ .Kind }}">
1212
{{ partial "gtm-body.html" }}
13-
<header>
13+
<header aria-label="Main site header">
1414
{{ partial "navbar.html" . }}
1515
</header>
1616
<div class="container-fluid td-outer">
@@ -22,7 +22,7 @@
2222
<div class="d-none d-xl-block col-xl-2 td-toc d-print-none">
2323
{{ partial "toc.html" . }}
2424
</div>
25-
<main class="col-12 col-md-8 col-xl-7 pl-md-5" role="main">
25+
<main class="col-12 col-md-8 col-xl-7 pl-md-5" role="main" aria-label="Article content">
2626
{{ partial "version-banner.html" . }}
2727
{{ if not .Site.Params.ui.breadcrumb_disable }}{{ partial "breadcrumb.html" . }}{{ end }}
2828
{{ if .Draft }}

docs/layouts/partials/footer.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{ $footer := getJSON "https://www.gooddata.com/learn-assets/js/footer-definition.json" }}
22

3-
<footer class="gd-footer">
3+
<footer class="gd-footer" aria-label="Page footer">
44
{{ if $footer.footer.bannerLinks }}
55
<ul class="gd-footer-banner-links gd-footer-links">
66
{{ range $index, $link := $footer.footer.bannerLinks }}

docs/layouts/swagger/baseof.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</head>
99
<body class="td-{{ .Kind }}">
1010
{{ partial "gtm-body.html" }}
11-
<header>
11+
<header aria-label="Main site header">
1212
{{ partial "navbar.html" . }}
1313
</header>
1414
<div class="container-fluid td-outer">
@@ -20,7 +20,7 @@
2020
<div class="d-none d-xl-block col-xl-2 td-toc d-print-none">
2121
{{ partial "toc.html" . }}
2222
</div>
23-
<main class="col-12 col-md-9 col-xl-7 pl-md-5" role="main">
23+
<main class="col-12 col-md-9 col-xl-7 pl-md-5" role="main" aria-label="Article content">
2424
{{ if not .Site.Params.ui.breadcrumb_disable }}{{ partial "breadcrumb.html" . }}{{ end }}
2525
<script src="/js/swagger-ui-bundle.js"></script>
2626
<script src="/js/swagger-ui-standalone-preset.js"></script>

0 commit comments

Comments
 (0)