Skip to content

Commit 5f652e0

Browse files
Merge pull request #1238 from gooddata/snapshot-master-dd6e5e0a-to-rel/dev
[bot] Merge master/dd6e5e0a into rel/dev
2 parents aa2f5d8 + dd6e5e0 commit 5f652e0

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

packages/gooddata-sdk/src/gooddata_sdk/compute/compute_to_sdk_converter.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
AllTimeFilter,
99
BoundedFilter,
1010
Filter,
11+
InlineFilter,
1112
MetricValueFilter,
1213
NegativeAttributeFilter,
1314
PositiveAttributeFilter,
@@ -133,6 +134,11 @@ def convert_filter(filter_dict: dict[str, Any]) -> Filter:
133134
value=f["value"],
134135
)
135136

137+
if "inline" in filter_dict:
138+
f = filter_dict["inline"]
139+
140+
return InlineFilter(maql=f["filter"])
141+
136142
raise ValueError(f"Unsupported filter definition type: {filter_dict}")
137143

138144
@staticmethod

packages/gooddata-sdk/tests/compute/test_compute_to_sdk_converter.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
ArithmeticMetric,
77
Attribute,
88
ComputeToSdkConverter,
9+
InlineFilter,
910
MetricValueFilter,
1011
NegativeAttributeFilter,
1112
PopDateMetric,
@@ -229,6 +230,22 @@ def test_ranking_filter_with_dimensionality_conversion():
229230
assert result.value == 5
230231

231232

233+
def test_inline_filter():
234+
filter_dict = json.loads(
235+
"""
236+
{
237+
"inline": {
238+
"filter": "{label/process_date.month} = \\"2025-02\\""
239+
}
240+
}
241+
"""
242+
)
243+
244+
result = ComputeToSdkConverter.convert_filter(filter_dict)
245+
assert isinstance(result, InlineFilter)
246+
assert result.maql == '{label/process_date.month} = "2025-02"'
247+
248+
232249
def test_simple_metric_conversion():
233250
metric_dict = json.loads(
234251
"""

0 commit comments

Comments
 (0)