Skip to content

Commit 67f0eb3

Browse files
committed
fix(ai): Update LLM endpoints
jira: GDAI-339 risk: low
1 parent ad9131b commit 67f0eb3

File tree

6 files changed

+1
-26
lines changed

6 files changed

+1
-26
lines changed

gooddata-sdk/gooddata_sdk/catalog/organization/entity_model/llm_endpoint.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ def init(
4848
id: str,
4949
title: str,
5050
token: str,
51-
description: Optional[str] = None,
5251
provider: Optional[str] = None,
5352
base_url: Optional[str] = None,
5453
llm_organization: Optional[str] = None,
@@ -59,7 +58,6 @@ def init(
5958
attributes=CatalogLlmEndpointAttributes(
6059
title=title,
6160
token=token,
62-
description=description,
6361
provider=provider,
6462
base_url=base_url,
6563
llm_organization=llm_organization,
@@ -73,7 +71,6 @@ def from_api(cls, entity: dict[str, Any]) -> CatalogLlmEndpoint:
7371
attr = CatalogLlmEndpointAttributes(
7472
title=safeget(ea, ["title"]),
7573
token="", # Token is not returned for security reasons
76-
description=safeget(ea, ["description"]),
7774
provider=safeget(ea, ["provider"]),
7875
base_url=safeget(ea, ["baseUrl"]),
7976
llm_organization=safeget(ea, ["llmOrganization"]),
@@ -100,7 +97,6 @@ def init(
10097
id: str,
10198
title: Optional[str] = None,
10299
token: Optional[str] = None,
103-
description: Optional[str] = None,
104100
provider: Optional[str] = None,
105101
base_url: Optional[str] = None,
106102
llm_organization: Optional[str] = None,
@@ -111,7 +107,6 @@ def init(
111107
attributes=CatalogLlmEndpointPatchAttributes(
112108
title=title,
113109
token=token,
114-
description=description,
115110
provider=provider,
116111
base_url=base_url,
117112
llm_organization=llm_organization,
@@ -124,7 +119,6 @@ def init(
124119
class CatalogLlmEndpointAttributes(Base):
125120
title: str
126121
token: str
127-
description: Optional[str] = None
128122
provider: Optional[str] = None
129123
base_url: Optional[str] = None
130124
llm_organization: Optional[str] = None
@@ -139,7 +133,6 @@ def client_class() -> type[JsonApiLlmEndpointInAttributes]:
139133
class CatalogLlmEndpointPatchAttributes(Base):
140134
title: Optional[str] = None
141135
token: Optional[str] = None
142-
description: Optional[str] = None
143136
provider: Optional[str] = None
144137
base_url: Optional[str] = None
145138
llm_organization: Optional[str] = None

gooddata-sdk/gooddata_sdk/catalog/organization/service.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,6 @@ def create_llm_endpoint(
574574
id: str,
575575
title: str,
576576
token: str,
577-
description: Optional[str] = None,
578577
provider: Optional[str] = None,
579578
base_url: Optional[str] = None,
580579
llm_organization: Optional[str] = None,
@@ -587,7 +586,6 @@ def create_llm_endpoint(
587586
id: Identifier of the LLM endpoint
588587
title: User-facing title of the LLM Provider
589588
token: The token to use to connect to the LLM provider
590-
description: Optional user-facing description of the LLM endpoint
591589
provider: Optional LLM provider name (e.g., "openai")
592590
base_url: Optional base URL for custom LLM endpoint
593591
llm_organization: Optional LLM organization identifier
@@ -600,7 +598,6 @@ def create_llm_endpoint(
600598
id=id,
601599
title=title,
602600
token=token,
603-
description=description,
604601
provider=provider,
605602
base_url=base_url,
606603
llm_organization=llm_organization,
@@ -617,7 +614,6 @@ def update_llm_endpoint(
617614
id: str,
618615
title: Optional[str] = None,
619616
token: Optional[str] = None,
620-
description: Optional[str] = None,
621617
provider: Optional[str] = None,
622618
base_url: Optional[str] = None,
623619
llm_organization: Optional[str] = None,
@@ -630,7 +626,6 @@ def update_llm_endpoint(
630626
id: Identifier of the LLM endpoint
631627
title: User-facing title of the LLM Provider
632628
token: The token to use to connect to the LLM provider. If not provided, the existing token will be preserved.
633-
description: User-facing description of the LLM endpoint
634629
provider: LLM provider name (e.g., "openai")
635630
base_url: Base URL for custom LLM endpoint
636631
llm_organization: LLM organization identifier
@@ -643,7 +638,6 @@ def update_llm_endpoint(
643638
id=id,
644639
title=title,
645640
token=token,
646-
description=description,
647641
provider=provider,
648642
base_url=base_url,
649643
llm_organization=llm_organization,

gooddata-sdk/tests/catalog/fixtures/organization/create_llm_endpoint.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ interactions:
7575
attributes:
7676
title: Test Endpoint 2
7777
token: secret-token-2
78-
description: Test Description
7978
provider: OPENAI
8079
baseUrl: https://api.example.com
8180
llmOrganization: org1

gooddata-sdk/tests/catalog/fixtures/organization/delete_llm_endpoint.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ interactions:
161161
to access it.
162162
status: 404
163163
title: Not Found
164-
traceId: af6c2c610c999d92ae5b97820b9370cb
164+
traceId: 85a65755a01301cfc27020eabbbdf90a
165165
- request:
166166
method: DELETE
167167
uri: http://localhost:3000/api/v1/entities/llmEndpoints/endpoint1

gooddata-sdk/tests/catalog/fixtures/organization/update_llm_endpoint.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ interactions:
139139
attributes:
140140
title: Updated Title 2
141141
token: new-token
142-
description: Updated Description
143142
provider: OPENAI
144143
baseUrl: https://api.updated.com
145144
llmOrganization: org2

gooddata-sdk/tests/catalog/test_catalog_organization.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,6 @@ def test_create_llm_endpoint(test_config):
464464
full_id = "endpoint2"
465465
full_title = "Test Endpoint 2"
466466
full_token = "secret-token-2"
467-
full_description = "Test Description"
468467
full_provider = "OPENAI"
469468
full_base_url = "https://api.example.com"
470469
full_llm_org = "org1"
@@ -474,7 +473,6 @@ def test_create_llm_endpoint(test_config):
474473
id=full_id,
475474
title=full_title,
476475
token=full_token,
477-
description=full_description,
478476
provider=full_provider,
479477
base_url=full_base_url,
480478
llm_organization=full_llm_org,
@@ -485,8 +483,6 @@ def test_create_llm_endpoint(test_config):
485483
assert llm_endpoint_2.attributes.title == full_title
486484
# Token is not returned in the API response for security reasons
487485
assert not llm_endpoint_2.attributes.token
488-
# Description is not returned in the API response. TODO: Check if this is correct.
489-
# assert llm_endpoint_2.attributes.description == full_description
490486
assert llm_endpoint_2.attributes.provider == full_provider
491487
assert llm_endpoint_2.attributes.base_url == full_base_url
492488
assert llm_endpoint_2.attributes.llm_organization == full_llm_org
@@ -523,7 +519,6 @@ def test_update_llm_endpoint(test_config):
523519
# Test with all optional parameters
524520
full_title = "Updated Title 2"
525521
full_token = "new-token"
526-
full_description = "Updated Description"
527522
full_provider = "OPENAI"
528523
full_base_url = "https://api.updated.com"
529524
full_llm_org = "org2"
@@ -533,7 +528,6 @@ def test_update_llm_endpoint(test_config):
533528
id=initial_id,
534529
title=full_title,
535530
token=full_token,
536-
description=full_description,
537531
provider=full_provider,
538532
base_url=full_base_url,
539533
llm_organization=full_llm_org,
@@ -545,8 +539,6 @@ def test_update_llm_endpoint(test_config):
545539
assert llm_endpoint_2.attributes.title == full_title
546540
# Token is not returned in the API response for security reasons
547541
assert not llm_endpoint_2.attributes.token
548-
# Description is not returned in the API response. TODO: Check if this is correct.
549-
# assert llm_endpoint_2.attributes.description == full_description
550542
assert llm_endpoint_2.attributes.provider == full_provider
551543
assert llm_endpoint_2.attributes.base_url == full_base_url
552544
assert llm_endpoint_2.attributes.llm_organization == full_llm_org
@@ -562,8 +554,6 @@ def test_update_llm_endpoint(test_config):
562554
# Token is not returned in the API response for security reasons
563555
assert not llm_endpoint_3.attributes.token
564556
# Verify other fields are preserved
565-
# Description is not returned in the API response. TODO: Check if this is correct.
566-
# assert llm_endpoint_3.attributes.description == full_description
567557
assert llm_endpoint_3.attributes.provider == full_provider
568558
assert llm_endpoint_3.attributes.base_url == full_base_url
569559
assert llm_endpoint_3.attributes.llm_organization == full_llm_org

0 commit comments

Comments
 (0)