Skip to content

Commit 92f0591

Browse files
committed
fix: remove update_oidc_parameters
There was a breaking change on the backend that rendered `update_oidc_parameters` unusable. OIDC was moved from the organization to the IdentityProvider entity; therefore, this API stopped working. Use `update_identity_provider` instead.
1 parent c4fdb6d commit 92f0591

File tree

6 files changed

+0
-1047
lines changed

6 files changed

+0
-1047
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ Steps:
124124
125125
```diff
126126
* [update_name](./update_name/)
127-
* [update_oidc_parameters](./update_oidc_parameters/)
128127
* [create_or_update_jwk](./create_or_update_jwk/)
129128
* [delete_jwk](./delete_jwk/)
130129
* [get_jwk](./get_jwk/)

docs/content/en/latest/administration/organization/_index.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ See [Manage Organizations](https://www.gooddata.com/docs/cloud/manage-deployment
1212
## Methods
1313

1414
* [update_name](./update_name/)
15-
* [update_oidc_parameters](./update_oidc_parameters/)
1615
* [create_or_update_jwk](./create_or_update_jwk/)
1716
* [delete_jwk](./delete_jwk/)
1817
* [get_jwk](./get_jwk/)
@@ -33,9 +32,4 @@ sdk = GoodDataSdk.create(host, token)
3332

3433
# Update organization name
3534
sdk.catalog_organization.update_name(name="new_organization_name")
36-
37-
# Update OIDC provider
38-
sdk.catalog_organization.update_oidc_parameters(oauth_client_id="oauth_client_id",
39-
oauth_issuer_location="oauth_issuer_location",
40-
oauth_client_secret="oauth_client_secret")
4135
```

docs/content/en/latest/administration/organization/update_oidc_parameters.md

Lines changed: 0 additions & 44 deletions
This file was deleted.

packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/service.py

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -41,40 +41,6 @@ def __init__(self, api_client: GoodDataApiClient) -> None:
4141

4242
# Entities API
4343

44-
def update_oidc_parameters(
45-
self,
46-
oauth_issuer_location: Optional[str] = None,
47-
oauth_client_id: Optional[str] = None,
48-
oauth_client_secret: Optional[str] = None,
49-
) -> None:
50-
"""Updates OIDC parameters of organization.
51-
52-
Args:
53-
oauth_issuer_location (Optional[str], optional):
54-
Issuer location. Defaults to None.
55-
oauth_client_id (Optional[str], optional):
56-
Public client identifier. Defaults to None.
57-
oauth_client_secret (Optional[str], optional):
58-
Client secret. Defaults to None.
59-
60-
Returns:
61-
None
62-
63-
Raises:
64-
ValueError:
65-
Parameters were not strictly all none or all string.
66-
"""
67-
parameters = [oauth_issuer_location, oauth_client_id, oauth_client_secret]
68-
if not all(p is not None for p in parameters) and any(p is not None for p in parameters):
69-
raise ValueError("All parameters have to be set to None or all parameters has to be string.")
70-
organization = self.get_organization()
71-
organization.attributes.oauth_issuer_location = oauth_issuer_location
72-
organization.attributes.oauth_client_id = oauth_client_id
73-
organization_document = CatalogOrganizationDocument(data=organization)
74-
self._entities_api.update_entity_organizations(
75-
organization.id, organization_document.to_api(oauth_client_secret=oauth_client_secret)
76-
)
77-
7844
def update_name(self, name: str) -> None:
7945
"""Updates the name of the organization.
8046

0 commit comments

Comments
 (0)