fix tox.ini, address mypy reports

Author: janmatzek

gooddata-pipelines/gooddata_pipelines/api/gooddata_sdk.py

@@ -3,6 +3,7 @@
 """Interaction with GoodData Cloud via the Gooddata Python SDK."""
 
 from pathlib import Path
+from typing import Callable
 
 from gooddata_sdk.catalog.permission.declarative_model.permission import (
     CatalogDeclarativeWorkspacePermissions,
@@ -23,8 +24,8 @@
 from gooddata_pipelines.api.utils import raise_with_context
 
 
-def apply_to_all_methods(decorator):
-    def decorate(cls):
+def apply_to_all_methods(decorator: Callable) -> Callable:
+    def decorate(cls: type) -> type:
         for attr in cls.__dict__:
             if callable(getattr(cls, attr)) and not attr.startswith("__"):
                 setattr(cls, attr, decorator(getattr(cls, attr)))

gooddata-pipelines/gooddata_pipelines/backup_and_restore/backup_manager.py

@@ -105,7 +105,7 @@ def store_user_data_filters(
         user_data_filters: dict,
         export_path: Path,
         ws_id: str,
-    ):
+    ) -> None:
         """Stores the user data filters in the specified export path."""
         os.mkdir(
             os.path.join(
@@ -136,7 +136,7 @@ def move_folder(source: Path, destination: Path) -> None:
         shutil.move(source, destination)
 
     @staticmethod
-    def write_to_yaml(path: str, source):
+    def write_to_yaml(path: str, source: Any) -> None:
         """Writes the source to a YAML file."""
         with open(path, "w") as outfile:
             yaml.dump(source, outfile)

gooddata-pipelines/gooddata_pipelines/backup_and_restore/storage/base_storage.py

@@ -13,6 +13,6 @@ def __init__(self, conf: BackupRestoreConfig):
         self.logger = LogObserver()
 
     @abc.abstractmethod
-    def export(self, folder, org_id):
+    def export(self, folder: str, org_id: str) -> None:
         """Exports the content of the folder to the storage."""
         raise NotImplementedError

gooddata-pipelines/gooddata_pipelines/backup_and_restore/storage/local_storage.py

@@ -15,14 +15,18 @@ class LocalStorage(BackupStorage):
     def __init__(self, conf: BackupRestoreConfig):
         super().__init__(conf)
 
-    def _export(self, folder, org_id, export_folder="local_backups") -> None:
+    def _export(
+        self, folder: str, org_id: str, export_folder: str = "local_backups"
+    ) -> None:
         """Copies the content of the folder to local storage as backup."""
         self.logger.info(f"Saving {org_id} to local storage")
         shutil.copytree(
             Path(folder), Path(Path.cwd(), export_folder), dirs_exist_ok=True
         )
 
-    def export(self, folder, org_id, export_folder="local_backups") -> None:
+    def export(
+        self, folder: str, org_id: str, export_folder: str = "local_backups"
+    ) -> None:
         """Copies the content of the folder to local storage as backup."""
         try:
             self._export(folder, org_id, export_folder)

gooddata-pipelines/gooddata_pipelines/backup_and_restore/storage/s3_storage.py

@@ -52,7 +52,7 @@ def _verify_connection(self) -> None:
                 f"Failed to connect to S3 bucket {self._config.bucket}: {e}"
             )
 
-    def export(self, folder, org_id) -> None:
+    def export(self, folder: str, org_id: str) -> None:
         """Uploads the content of the folder to S3 as backup."""
         storage_path = f"{self._config.bucket}/{self._backup_path}"
         self.logger.info(f"Uploading {org_id} to {storage_path}")

gooddata-pipelines/tox.ini

@@ -1,13 +1,16 @@
 # (C) 2025 GoodData Corporation
 [tox]
-envlist = py3{10,11,12,13}
+envlist = py3{10,11,12,13}, mypy
 
 [testenv]
 deps =
     pytest
     pytest-mock
     poetry
-commands = poetry run pytest
+commands =
+    poetry install
+    poetry install --extras dev
+    poetry run pytest
 
 [testenv:mypy]
 basepython = python3.13