fix(sdk): support ui identifier ref conversion

Conversion logic adjusted to follow ui-sdk counterpart.
Hence somewhat chaotic usage of defaultType values in some cases.

risk: low
JIRA: CQ-1080

Author: Tjev

gooddata-sdk/gooddata_sdk/utils.py

@@ -9,7 +9,7 @@
 from enum import Enum, auto
 from pathlib import Path
 from shutil import rmtree
-from typing import Any, Callable, NamedTuple, Union, cast, no_type_check
+from typing import Any, Callable, NamedTuple, Optional, Union, cast, no_type_check
 from warnings import warn
 from xml.etree import ElementTree as ET
 
@@ -396,28 +396,33 @@ def read_json(path: Union[str, Path]) -> Any:
         return json.loads(f.read())
 
 
-def ref_extract_obj_id(ref: dict[str, Any]) -> ObjId:
+def ref_extract_obj_id(ref: dict[str, Any], type: Optional[str] = None) -> ObjId:
     """
     Extracts ObjId from a ref dictionary.
     :param ref: the ref to extract from
+    :param type: the type of the object to fall back to in case of string identifier
     :return: the extracted ObjId
     :raises ValueError: if the ref is not an identifier
     """
     if "identifier" in ref:
+        if isinstance(ref["identifier"], str):
+            if not type:
+                raise ValueError("identifier is a string, but fallback type is not provided")
+            return ObjId(id=ref["identifier"], type=type)
         return ObjId(id=ref["identifier"]["id"], type=ref["identifier"]["type"])
 
     raise ValueError("invalid ref. must be identifier")
 
 
-def ref_extract(ref: dict[str, Any]) -> Union[str, ObjId]:
+def ref_extract(ref: dict[str, Any], type: Optional[str] = None) -> Union[str, ObjId]:
     """
     Extracts an object id from a ref dictionary: either an identifier or a localIdentifier.
     :param ref: the ref to extract from
     :return: thr extracted object id
     :raises ValueError: if the ref is not an identifier or localIdentifier
     """
     try:
-        return ref_extract_obj_id(ref)
+        return ref_extract_obj_id(ref, type)
     except ValueError:
         pass
 

gooddata-sdk/gooddata_sdk/visualization.py

@@ -394,7 +394,11 @@ def show_all_values(self) -> Optional[bool]:
         return self._a.get("showAllValues")
 
     def as_computable(self) -> Attribute:
-        return Attribute(local_id=self.local_id, label=ref_extract(self.label), show_all_values=self.show_all_values)
+        return Attribute(
+            local_id=self.local_id,
+            label=ref_extract(self.label),  # , "label"),
+            show_all_values=self.show_all_values,
+        )
 
     def __str__(self) -> str:
         return self.__repr__()