Skip to content

Commit ba4d001

Browse files
fiedlrfiedlr
committed
fix: fixtures for isNullable
risk: nonprod
1 parent 6cdcd30 commit ba4d001

File tree

4 files changed

+119
-63
lines changed

4 files changed

+119
-63
lines changed

‎packages/gooddata-sdk/tests/catalog/expected/declarative_ldm_with_sql_dataset.json‎

Lines changed: 40 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
"description": "Campaign channel id",
4141
"tags": [
4242
"Campaign channels"
43-
]
43+
],
44+
"isNullable": false
4445
},
4546
{
4647
"id": "campaign_channels.category",
@@ -51,7 +52,8 @@
5152
"description": "Category",
5253
"tags": [
5354
"Campaign channels"
54-
]
55+
],
56+
"isNullable": true
5557
},
5658
{
5759
"id": "type",
@@ -62,7 +64,8 @@
6264
"description": "Type",
6365
"tags": [
6466
"Campaign channels"
65-
]
67+
],
68+
"isNullable": true
6669
}
6770
],
6871
"facts": [
@@ -74,7 +77,8 @@
7477
"description": "Budget",
7578
"tags": [
7679
"Campaign channels"
77-
]
80+
],
81+
"isNullable": true
7882
},
7983
{
8084
"id": "spend",
@@ -84,7 +88,8 @@
8488
"description": "Spend",
8589
"tags": [
8690
"Campaign channels"
87-
]
91+
],
92+
"isNullable": true
8893
}
8994
],
9095
"dataSourceTableId": {
@@ -121,7 +126,8 @@
121126
"description": "Campaign name",
122127
"tags": [
123128
"Campaigns"
124-
]
129+
],
130+
"isNullable": true
125131
},
126132
{
127133
"id": "campaigns.campaign_id",
@@ -132,7 +138,8 @@
132138
"description": "Campaign id",
133139
"tags": [
134140
"Campaigns"
135-
]
141+
],
142+
"isNullable": false
136143
}
137144
],
138145
"facts": [],
@@ -170,7 +177,8 @@
170177
"description": "Customer id",
171178
"tags": [
172179
"Customers"
173-
]
180+
],
181+
"isNullable": false
174182
},
175183
{
176184
"id": "customers.customer_name",
@@ -181,7 +189,8 @@
181189
"description": "Customer name",
182190
"tags": [
183191
"Customers"
184-
]
192+
],
193+
"isNullable": true
185194
},
186195
{
187196
"id": "customers.region",
@@ -192,7 +201,8 @@
192201
"description": "Region",
193202
"tags": [
194203
"Customers"
195-
]
204+
],
205+
"isNullable": true
196206
},
197207
{
198208
"id": "customers.state",
@@ -206,7 +216,8 @@
206216
"tags": [
207217
"Customers"
208218
],
209-
"valueType": "GEO"
219+
"valueType": "GEO",
220+
"isNullable": true
210221
}
211222
],
212223
"sourceColumn": "state",
@@ -215,7 +226,8 @@
215226
"description": "State",
216227
"tags": [
217228
"Customers"
218-
]
229+
],
230+
"isNullable": true
219231
}
220232
],
221233
"facts": [],
@@ -322,7 +334,8 @@
322334
"description": "Order id",
323335
"tags": [
324336
"Order lines"
325-
]
337+
],
338+
"isNullable": true
326339
},
327340
{
328341
"id": "order_lines.order_line_id",
@@ -333,7 +346,8 @@
333346
"description": "Order line id",
334347
"tags": [
335348
"Order lines"
336-
]
349+
],
350+
"isNullable": false
337351
},
338352
{
339353
"id": "order_lines.order_status",
@@ -344,7 +358,8 @@
344358
"description": "Order status",
345359
"tags": [
346360
"Order lines"
347-
]
361+
],
362+
"isNullable": true
348363
}
349364
],
350365
"facts": [
@@ -356,7 +371,8 @@
356371
"description": "Price",
357372
"tags": [
358373
"Order lines"
359-
]
374+
],
375+
"isNullable": true
360376
},
361377
{
362378
"id": "order_lines.quantity",
@@ -366,7 +382,8 @@
366382
"description": "Quantity",
367383
"tags": [
368384
"Order lines"
369-
]
385+
],
386+
"isNullable": true
370387
}
371388
],
372389
"dataSourceTableId": {
@@ -413,7 +430,8 @@
413430
"description": "Product name",
414431
"tags": [
415432
"Products"
416-
]
433+
],
434+
"isNullable": true
417435
},
418436
{
419437
"id": "products.category",
@@ -424,7 +442,8 @@
424442
"description": "Category",
425443
"tags": [
426444
"Products"
427-
]
445+
],
446+
"isNullable": true
428447
},
429448
{
430449
"id": "products.product_id",
@@ -435,7 +454,8 @@
435454
"description": "Product id",
436455
"tags": [
437456
"Products"
438-
]
457+
],
458+
"isNullable": false
439459
}
440460
],
441461
"facts": [],

‎packages/gooddata-sdk/tests/catalog/expected/declarative_pdm_ldm_request.json‎

Lines changed: 40 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@
55
{
66
"data_type": "NUMERIC",
77
"isPrimaryKey": false,
8-
"name": "budget"
8+
"name": "budget",
9+
"isNullable": true
910
},
1011
{
1112
"data_type": "STRING",
1213
"isPrimaryKey": true,
13-
"name": "campaign_channel_id"
14+
"name": "campaign_channel_id",
15+
"isNullable": false
1416
},
1517
{
1618
"data_type": "INT",
@@ -22,17 +24,20 @@
2224
{
2325
"data_type": "STRING",
2426
"isPrimaryKey": false,
25-
"name": "category"
27+
"name": "category",
28+
"isNullable": true
2629
},
2730
{
2831
"data_type": "NUMERIC",
2932
"isPrimaryKey": false,
30-
"name": "spend"
33+
"name": "spend",
34+
"isNullable": true
3135
},
3236
{
3337
"data_type": "STRING",
3438
"isPrimaryKey": false,
35-
"name": "type"
39+
"name": "type",
40+
"isNullable": true
3641
}
3742
],
3843
"id": "campaign_channels",
@@ -47,12 +52,14 @@
4752
{
4853
"data_type": "INT",
4954
"isPrimaryKey": true,
50-
"name": "campaign_id"
55+
"name": "campaign_id",
56+
"isNullable": false
5157
},
5258
{
5359
"data_type": "STRING",
5460
"isPrimaryKey": false,
55-
"name": "campaign_name"
61+
"name": "campaign_name",
62+
"isNullable": true
5663
}
5764
],
5865
"id": "campaigns",
@@ -67,27 +74,32 @@
6774
{
6875
"data_type": "INT",
6976
"isPrimaryKey": true,
70-
"name": "customer_id"
77+
"name": "customer_id",
78+
"isNullable": false
7179
},
7280
{
7381
"data_type": "STRING",
7482
"isPrimaryKey": false,
75-
"name": "customer_name"
83+
"name": "customer_name",
84+
"isNullable": true
7685
},
7786
{
7887
"data_type": "STRING",
7988
"isPrimaryKey": false,
80-
"name": "geo__state__location"
89+
"name": "geo__state__location",
90+
"isNullable": true
8191
},
8292
{
8393
"data_type": "STRING",
8494
"isPrimaryKey": false,
85-
"name": "region"
95+
"name": "region",
96+
"isNullable": true
8697
},
8798
{
8899
"data_type": "STRING",
89100
"isPrimaryKey": false,
90-
"name": "state"
101+
"name": "state",
102+
"isNullable": true
91103
}
92104
],
93105
"id": "customers",
@@ -121,22 +133,26 @@
121133
{
122134
"data_type": "STRING",
123135
"isPrimaryKey": false,
124-
"name": "order_id"
136+
"name": "order_id",
137+
"isNullable": true
125138
},
126139
{
127140
"data_type": "STRING",
128141
"isPrimaryKey": true,
129-
"name": "order_line_id"
142+
"name": "order_line_id",
143+
"isNullable": false
130144
},
131145
{
132146
"data_type": "STRING",
133147
"isPrimaryKey": false,
134-
"name": "order_status"
148+
"name": "order_status",
149+
"isNullable": true
135150
},
136151
{
137152
"data_type": "NUMERIC",
138153
"isPrimaryKey": false,
139-
"name": "price"
154+
"name": "price",
155+
"isNullable": true
140156
},
141157
{
142158
"data_type": "INT",
@@ -148,7 +164,8 @@
148164
{
149165
"data_type": "NUMERIC",
150166
"isPrimaryKey": false,
151-
"name": "quantity"
167+
"name": "quantity",
168+
"isNullable": true
152169
},
153170
{
154171
"data_type": "STRING",
@@ -173,17 +190,20 @@
173190
{
174191
"data_type": "STRING",
175192
"isPrimaryKey": false,
176-
"name": "category"
193+
"name": "category",
194+
"isNullable": true
177195
},
178196
{
179197
"data_type": "INT",
180198
"isPrimaryKey": true,
181-
"name": "product_id"
199+
"name": "product_id",
200+
"isNullable": false
182201
},
183202
{
184203
"data_type": "STRING",
185204
"isPrimaryKey": false,
186-
"name": "product_name"
205+
"name": "product_name",
206+
"isNullable": true
187207
}
188208
],
189209
"id": "products",

‎packages/gooddata-sdk/tests/catalog/load/gooddata_layouts/default/workspaces/demo/ldm/datasets/customers.yaml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ attributes:
3232
id: geo__state__location
3333
sourceColumn: geo__state__location
3434
sourceColumnDataType: STRING
35-
locale: en-US
36-
translations:
37-
- locale: cs-CZ
38-
sourceColumn: geo__state__location_cz
3935
tags:
4036
- Customers
4137
title: Location

0 commit comments

Comments
 (0)