fix: fix loading aggregated facts for entity dataset

JIRA: CQ-1236
risk: low

Author: pcerny

gooddata-sdk/gooddata_sdk/catalog/entity.py

@@ -11,7 +11,7 @@
 
 from gooddata_sdk.catalog.base import Base, JsonApiEntityBase
 from gooddata_sdk.compute.model.base import ObjId
-from gooddata_sdk.utils import AllPagedEntities
+from gooddata_sdk.utils import AllPagedEntities, safeget_list
 
 T = TypeVar("T", bound="AttrCatalogEntity")
 
@@ -84,6 +84,10 @@ def from_api(
     def client_class() -> Any:
         return NotImplemented
 
+    def _relation_entity_from_side_loads(self, entity: builtins.type[T], path: list[str]) -> list[T]:
+        related_fact_ids = [(x.get("id"), x.get("type")) for x in safeget_list(self.json_api_relationships, path)]
+        return [entity.from_api(sl) for sl in self.json_api_side_loads if (sl["id"], sl["type"]) in related_fact_ids]
+
 
 class CatalogEntity:
     def __init__(self, entity: dict[str, Any]) -> None:

gooddata-sdk/gooddata_sdk/catalog/workspace/content_service.py

@@ -79,7 +79,7 @@ def get_full_catalog(self, workspace_id: str, inject_valid_objects_func: bool =
         get_datasets = functools.partial(
             self._entities_api.get_all_entities_datasets,
             workspace_id,
-            include=["attributes", "facts"],
+            include=["attributes", "facts", "aggregatedFacts"],
             _check_return_type=False,
         )
 

gooddata-sdk/gooddata_sdk/catalog/workspace/entity_model/content_objects/dataset.py

@@ -106,9 +106,7 @@ class CatalogAggregatedFact(AttrCatalogEntity):
     def client_class() -> Any:
         return JsonApiAggregatedFactOut
 
-    def as_computable(self) -> Metric:
-        return SimpleMetric(local_id=self.id, item=self.obj_id)
-
+    # as_computable skipped because aggregated fact cannot be ever used in metric
     # TODO - dataset?
 
 
@@ -131,28 +129,22 @@ def generate_attributes_from_api(self) -> list[CatalogAttribute]:
         repr=False,
         default=attr.Factory(lambda self: self.generate_attributes_from_api(), takes_self=True),
     )
-
-    def generate_facts_from_api(self) -> list[CatalogFact]:
-        related_fact_ids = [x.get("id") for x in safeget_list(self.json_api_relationships, ["facts", "data"])]
-        return [
-            CatalogFact.from_api(sl)
-            for sl in self.json_api_side_loads
-            if sl["type"] == "fact" and sl["id"] in related_fact_ids
-        ]
-
     facts: list[CatalogFact] = attr.field(
         repr=False,
-        default=attr.Factory(lambda self: self.generate_facts_from_api(), takes_self=True),
+        default=attr.Factory(
+            lambda self: self._relation_entity_from_side_loads(CatalogFact, ["facts", "data"]), takes_self=True
+        ),
     )
-
-    # TODO: Doublecheck if we shouldn't do something like for facts
     aggregated_facts: Optional[list[CatalogAggregatedFact]] = attr.field(
-        default=attr.Factory(lambda self: self.json_api_attributes.get("aggregatedFacts"), takes_self=True),
+        repr=False,
+        default=attr.Factory(
+            lambda self: self._relation_entity_from_side_loads(CatalogAggregatedFact, ["aggregatedFacts", "data"]),
+            takes_self=True,
+        ),
     )
     precedence: Optional[int] = attr.field(
         default=attr.Factory(lambda self: self.json_api_attributes.get("precedence"), takes_self=True)
     )
-
     grain: Optional[list] = attr.field(
         default=attr.Factory(lambda self: self.json_api_attributes.get("grain"), takes_self=True)
     )