Merge pull request #971 from chrisbonilla95/cbon-lx-691-databricks-ds-token-cred-fix

chrisbonilla95 · web-flow · commit ca10fe22871f · 2025-02-06T10:59:52.000+01:00
fix: proper cred loading for Databricks pt2.
diff --git a/gooddata-sdk/gooddata_sdk/catalog/data_source/service.py b/gooddata-sdk/gooddata_sdk/catalog/data_source/service.py
@@ -476,7 +476,7 @@ def test_data_sources_connection(
                         declarative_data_source.to_test_request(token=token)
                     )
                 elif declarative_data_source.type == DATABRICKS_TYPE:
-                    if declarative_data_source.client_id is not None:
+                    if declarative_data_source.client_id and declarative_data_source.client_id.strip():
                         client_secret = ClientSecretCredentialsFromFile.client_secret_from_file(
                             credentials[declarative_data_source.id]
                         )

Original file line number	Diff line number	Diff line change
`@@ -476,7 +476,7 @@ def test_data_sources_connection(`
`476`	`476`	`declarative_data_source.to_test_request(token=token)`
`477`	`477`	`)`
`478`	`478`	`elif declarative_data_source.type == DATABRICKS_TYPE:`
`479`		`- if declarative_data_source.client_id is not None:`
	`479`	`+ if declarative_data_source.client_id and declarative_data_source.client_id.strip():`
`480`	`480`	`client_secret = ClientSecretCredentialsFromFile.client_secret_from_file(`
`481`	`481`	`credentials[declarative_data_source.id]`
`482`	`482`	`)`