Skip to content

Commit cff4a6c

Browse files
Merge pull request #992 from gooddata/snapshot-master-377dfef8-to-rel/dev
[bot] Merge master/377dfef8 into rel/dev
2 parents 88966cb + 377dfef commit cff4a6c

File tree

1 file changed

+13
-0
lines changed
  • gooddata-sdk/gooddata_sdk/catalog/data_source/validation

1 file changed

+13
-0
lines changed

gooddata-sdk/gooddata_sdk/catalog/data_source/validation/data_source.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@ def __init__(self, data_source_service: CatalogDataSourceService):
1010
self._ds_service = data_source_service
1111

1212
def validate_ldm(self, model: CatalogDeclarativeModel) -> None:
13+
"""
14+
Validates that referenced data sources in LDM actually exist.
15+
If they do not exist, raises ValueError.
16+
17+
Returns:
18+
None
19+
"""
1320
if model.ldm is not None:
1421
ldm_ds_in_use = set(
1522
dataset.data_source_table_id.data_source_id
@@ -19,6 +26,12 @@ def validate_ldm(self, model: CatalogDeclarativeModel) -> None:
1926
self.validate_data_source_ids(ldm_ds_in_use)
2027

2128
def validate_data_source_ids(self, data_source_ids: set[str]) -> None:
29+
"""
30+
Compares data source ids with existing data sources in the catalog.
31+
32+
Returns:
33+
None
34+
"""
2235
full_ds_set = set(data_source.id for data_source in self._ds_service.list_data_sources())
2336
diff_ds = data_source_ids - full_ds_set
2437
if len(diff_ds) != 0:

0 commit comments

Comments
 (0)