Skip to content

Commit ffeb6ec

Browse files
committed
feat: add new fields regarding NULL values
jira: CQ-1959 risk: low
1 parent bc9fcd8 commit ffeb6ec

File tree

11 files changed

+3046
-28
lines changed

11 files changed

+3046
-28
lines changed

packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/action_model/requests/ldm_request.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ class CatalogGenerateLdmRequest(Base):
5151
wdf_prefix: Optional[str] = None
5252
pdm: Optional[CatalogPdmLdmRequest] = None
5353
workspace_id: Optional[str] = None
54+
translation_prefix: Optional[str] = None
5455

5556
@staticmethod
5657
def client_class() -> type[GenerateLdmRequest]:

packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/declarative_model/physical_model/column.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ class CatalogDeclarativeColumn(Base):
1616
is_primary_key: Optional[bool] = None
1717
referenced_table_id: Optional[str] = None
1818
referenced_table_column: Optional[str] = None
19+
is_nullable: Optional[bool] = None
20+
null_value: Optional[str] = None
1921

2022
@staticmethod
2123
def client_class() -> type[DeclarativeColumn]:

packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/logical_model/dataset/dataset.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ class CatalogDeclarativeAttribute(Base):
8282
tags: Optional[list[str]] = None
8383
is_hidden: Optional[bool] = None
8484
locale: Optional[str] = None
85+
is_nullable: Optional[bool] = None
86+
null_value: Optional[str] = None
8587

8688
@staticmethod
8789
def client_class() -> type[DeclarativeAttribute]:
@@ -97,6 +99,8 @@ class CatalogDeclarativeFact(Base):
9799
description: Optional[str] = None
98100
tags: Optional[list[str]] = None
99101
is_hidden: Optional[bool] = None
102+
is_nullable: Optional[bool] = None
103+
null_value: Optional[str] = None
100104

101105
@staticmethod
102106
def client_class() -> type[DeclarativeFact]:
@@ -121,6 +125,8 @@ class CatalogDeclarativeAggregatedFact(Base):
121125
source_column_data_type: Optional[str] = None
122126
description: Optional[str] = None
123127
tags: Optional[list[str]] = None
128+
is_nullable: Optional[bool] = None
129+
null_value: Optional[str] = None
124130

125131
@staticmethod
126132
def client_class() -> type[DeclarativeAggregatedFact]:
@@ -171,6 +177,8 @@ class CatalogDeclarativeLabel(Base):
171177
locale: Optional[str] = None
172178
translations: Optional[list[CatalogDeclarativeLabelTranslation]] = None
173179
geo_area_config: Optional[CatalogGeoAreaConfig] = None
180+
is_nullable: Optional[bool] = None
181+
null_value: Optional[str] = None
174182

175183
@staticmethod
176184
def client_class() -> type[DeclarativeLabel]:
@@ -203,6 +211,8 @@ class CatalogDeclarativeReference(Base):
203211
source_columns: Optional[list[str]] = None
204212
source_column_data_types: Optional[list[str]] = None
205213
sources: Optional[list[CatalogDeclarativeReferenceSource]] = None
214+
is_nullable: Optional[bool] = None
215+
null_value: Optional[str] = None
206216

207217
@staticmethod
208218
def client_class() -> type[DeclarativeReference]:

packages/gooddata-sdk/tests/catalog/expected/declarative_ldm.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -247,19 +247,12 @@
247247
{
248248
"description": "Location",
249249
"id": "geo__state__location",
250-
"locale": "en-US",
251250
"sourceColumn": "geo__state__location",
252251
"sourceColumnDataType": "STRING",
253252
"tags": [
254253
"Customers"
255254
],
256255
"title": "Location",
257-
"translations": [
258-
{
259-
"locale": "cs-CZ",
260-
"sourceColumn": "geo__state__location_cz"
261-
}
262-
],
263256
"valueType": "GEO"
264257
}
265258
],

packages/gooddata-sdk/tests/catalog/expected/declarative_workspaces_snake_case.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -261,13 +261,6 @@
261261
"source_column": "geo__state__location",
262262
"source_column_data_type": "STRING",
263263
"description": "Location",
264-
"locale": "en-US",
265-
"translations": [
266-
{
267-
"locale": "cs-CZ",
268-
"source_column": "geo__state__location_cz"
269-
}
270-
],
271264
"tags": [
272265
"Customers"
273266
],

packages/gooddata-sdk/tests/catalog/load/workspace_content/gooddata_layouts/default/workspaces/demo_testing/ldm/datasets/customers.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ attributes:
3232
id: geo__state__location
3333
sourceColumn: geo__state__location
3434
sourceColumnDataType: STRING
35-
locale: en-US
36-
translations:
37-
- locale: cs-CZ
38-
sourceColumn: geo__state__location_cz
3935
tags:
4036
- Customers
4137
title: Location

0 commit comments

Comments
 (0)