From 50665a31421357336789f6cfe559c033eb1881f3 Mon Sep 17 00:00:00 2001 From: Jan Kadlec Date: Thu, 3 Jul 2025 08:40:23 +0200 Subject: [PATCH] fix: mypy findings mypy in some cases complains about `_dict_to_filter_by` and GoodDataSdk initialization in GoodPandas. JIRA: TRIVIAL risk: low --- gooddata-pandas/gooddata_pandas/good_pandas.py | 2 +- gooddata-sdk/gooddata_sdk/catalog/filter_by.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gooddata-pandas/gooddata_pandas/good_pandas.py b/gooddata-pandas/gooddata_pandas/good_pandas.py index 5bd2dfaf9..1ae224068 100644 --- a/gooddata-pandas/gooddata_pandas/good_pandas.py +++ b/gooddata-pandas/gooddata_pandas/good_pandas.py @@ -39,7 +39,7 @@ def __init__( """ if headers_host is not None: custom_headers_["Host"] = headers_host - self._sdk = GoodDataSdk.create(host, token, USER_AGENT, **custom_headers_) + self._sdk = GoodDataSdk.create(host, token, USER_AGENT, executions_cancellable=False, **custom_headers_) self._series_per_ws: dict[str, SeriesFactory] = dict() self._frames_per_ws: dict[str, DataFrameFactory] = dict() diff --git a/gooddata-sdk/gooddata_sdk/catalog/filter_by.py b/gooddata-sdk/gooddata_sdk/catalog/filter_by.py index 4c3e85bd3..c6961c7c6 100644 --- a/gooddata-sdk/gooddata_sdk/catalog/filter_by.py +++ b/gooddata-sdk/gooddata_sdk/catalog/filter_by.py @@ -1,6 +1,8 @@ # (C) 2024 GoodData Corporation from __future__ import annotations +from typing import Optional + import attr from gooddata_api_client.model.filter_by import FilterBy @@ -9,7 +11,7 @@ @attr.s(auto_attribs=True, kw_only=True) class CatalogFilterBy(Base): - label_type: str + label_type: Optional[str] @staticmethod def client_class() -> type[FilterBy]: